Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank window on SIGTERM #15440

Closed
bagage opened this issue Oct 12, 2020 · 3 comments
Closed

Blank window on SIGTERM #15440

bagage opened this issue Oct 12, 2020 · 3 comments

Comments

@bagage
Copy link

bagage commented Oct 12, 2020

Description

When running low memory using the Electron app, element-desktop renderer process is getting killed (because it's the highest consumer), resulting in a blank window:

image

The problem is: you cannot do anything but stop Element and start it again.

Other Electron apps (for instance Slack), keeps the menu bar with the "Force refresh" button available, resulting in the renderer being restarted, which fixes the problem.

Steps to reproduce

  1. Find the element-desktop render PID ps aux | grep 'element-desktop --type=renderer'
  2. Kill it with SIGTERM: kill -15 $pid

--> element-desktop shows blank window.

Version information

  • Platform: web (in-browser) or desktop? desktop

  • OS: Windows, macOS, Ubuntu, Arch Linux, etc? Ubuntu

  • Version: 1.x.y 1.7.8 olm 3.1.3

@turt2live
Copy link
Member

This is largely the same root cause as #4264 - closing in favour of that

@bagage
Copy link
Author

bagage commented Oct 12, 2020

Strictly speaking, I do not think they share the same root cause: #4264 is about handling big file uploads (the fix would probably mean using less memory when opening big files).

This one is about fixing the problem that arises when no memory is left and the renderer is killed. It can be because of a big file upload, or because another application (say make -j4) is consuming many memory, resulting in element renderer to be killed. The fix here would be to at least have a button to restart the renderer, nothing related to memory at all.

@turt2live
Copy link
Member

#4264's root cause is memory exhaustion, which causes the rendering process to crash. The fix is to make the rendering process not crash, or if it does then take the rest of the app with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants