Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit testing. #144

Closed
ara4n opened this issue Aug 30, 2015 · 5 comments
Closed

Unit testing. #144

ara4n opened this issue Aug 30, 2015 · 5 comments
Labels
P2 T-Task Tasks for the team like planning

Comments

@ara4n
Copy link
Member

ara4n commented Aug 30, 2015

No description provided.

@ara4n ara4n added the T-Task Tasks for the team like planning label Aug 30, 2015
@ara4n ara4n added P2 T-Task Tasks for the team like planning and removed T-Task Tasks for the team like planning labels Sep 7, 2015
@ara4n ara4n modified the milestone: Ragnarok Nov 29, 2015
@ara4n ara4n removed this from the Ragnarok milestone Apr 13, 2016
@pafcu
Copy link
Contributor

pafcu commented Dec 15, 2017

Some unit tests exist. Does this issue refer to some specific unit tests, or could this issue be closed?

@turt2live
Copy link
Member

I believe it's more targeted as an ever-increasing goal to have more unit tests. The few that do exist have some coverage, but as always there can be more ;)

@pafcu
Copy link
Contributor

pafcu commented Dec 15, 2017

Right, but does an issue that just say "Unit testing" contribute to that effort? I don't think anyone will forget that unit tests are needed. Perhaps this could then be a place to collect what unittests are missing currently?

@turt2live
Copy link
Member

To be honest, I misread the age of this particular issue. If it were updated with a list of test cases to add, then it might be useful as a tracker issue.

@ara4n
Copy link
Member Author

ara4n commented Dec 15, 2017

it was more "we need UT framework" ,which didn't exist at the time. nowadays it does!

@ara4n ara4n closed this as completed Dec 15, 2017
t3chguy added a commit that referenced this issue Oct 17, 2024
@t3chguy
Update design of files list in right panel (#144)
0750625 
* Update design of files list in right panel

Signed-off-by: Michael Telatynski <[email protected]>

* Make i18n script happier

Signed-off-by: Michael Telatynski <[email protected]>

* Improve coverage

Signed-off-by: Michael Telatynski <[email protected]>

* Improve coverage

Signed-off-by: Michael Telatynski <[email protected]>

* Improve coverage

Signed-off-by: Michael Telatynski <[email protected]>

* Discard changes to src/components/structures/MessagePanel.tsx

* Iterate

Signed-off-by: Michael Telatynski <[email protected]>

* Iterate

Signed-off-by: Michael Telatynski <[email protected]>

* Iterate

Signed-off-by: Michael Telatynski <[email protected]>

* Update tests

Signed-off-by: Michael Telatynski <[email protected]>

* Fix flaky screenshot test

Signed-off-by: Michael Telatynski <[email protected]>

* Update screenshot

Signed-off-by: Michael Telatynski <[email protected]>

---------

Signed-off-by: Michael Telatynski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pafcu @turt2live @ara4n