Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting up E2EE on a new login doesn't block initial sync #12953

Closed
ara4n opened this issue Mar 31, 2020 · 4 comments
Closed

Setting up E2EE on a new login doesn't block initial sync #12953

ara4n opened this issue Mar 31, 2020 · 4 comments

Comments

@ara4n
Copy link
Member

ara4n commented Mar 31, 2020

Resulting in the initial sync exploding in attempts to decrypt undecryptable messages, rather than just waiting until E2EE has been set up.

@ara4n ara4n added the T-Defect label Mar 31, 2020
@ara4n
Copy link
Member Author

ara4n commented Mar 31, 2020

I think this basically breaks self-verification, because the self-verif to-device msgs get blocked behind the explosion of initialsync traffic

@jryans
Copy link
Collaborator

jryans commented Mar 31, 2020

Hmm, I have definitely seen self-verif work fine, so perhaps it only "breaks" for large accounts then...?

I am a bit worried we might rely on some client APIs that expect an operational sync to be running, so I am wary of changing this just before release...

@jryans
Copy link
Collaborator

jryans commented Apr 9, 2020

In #12981 (comment), we took a decision that we should gate on initial sync before complete security, so this may be resolved soonish.

@ara4n
Copy link
Member Author

ara4n commented Apr 17, 2020

this is now resolved, i think?

@ara4n ara4n closed this as completed Apr 17, 2020
t3chguy pushed a commit that referenced this issue Oct 17, 2024
* Update browserslist

* Increment version in user-agent string

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: R Midhun Suresh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants