Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically offer using turn.matrix.org when a call fails, and it is disabled #12937

Open
notramo opened this issue Mar 30, 2020 · 4 comments
Labels
A-VoIP O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement

Comments

@notramo
Copy link

notramo commented Mar 30, 2020

When a call fails and turn.matrix.org is disabled, automatically show a dialog:
This Matrix server doesn't provide call support (TURN/STUN). Enable using fallback turn.matrix.org call server?
With the choices: Yes and No and a checkbox Remember my setting.

@dbkr
Copy link
Member

dbkr commented Mar 31, 2020

I thought this was a thing that should be happening at the moment?

@jryans
Copy link
Collaborator

jryans commented Mar 31, 2020

We do show a dialog like this, but I believe we only show it once and then proceed silently in the future, whereas it sounds like @notramo would like to always see a dialog by default, but with an option to remember it if desired...

But that's just a guess, so @notramo please let us know if that's right. 😄

@notramo
Copy link
Author

notramo commented Mar 31, 2020

I tried it with a HS which offers no TURN/STUN server. The call simply failed with an error message "(could not connect media)" in the timeline at the call hangup event.
It is not offered automatically to turn it on, you have to go to Settings -> Voice & Video to enable it even at the first time. It is unintuitive.
The user should be able to enable it with 1 click after a failed call.

whereas it sounds like @notramo would like to always see a dialog by default, but with an option to remember it if desired...

This could be a solution too. Newbies may click "No." first time, because they don't know what it is. When another user explains in text what to do to enable call this should be sufficient: "Click Yes in the dialog after the failed call to enable fallback call server."
Currently text message explaining would be like: "Go to Settings -> Voice & Video then search for an option that includes turn.matrix.org and enable that and come back to start the call."

@notramo
Copy link
Author

notramo commented Mar 31, 2020

The best approach would be to automatically detect it somehow before inserting the call start event (maybe add a Synapse endpoint) if a server provides TURN/STUN. If it doesn't provide, then Riot should show a dialog: Can't place call, because this homeserver doesn't provide a TURN server required for the call feature. Do you want to enable fallback turn.matrix.org call server?

@jryans jryans removed the Z-UI/UX label Mar 8, 2021
@SimonBrandner SimonBrandner added O-Occasional Affects or can be seen by some users regularly or most users rarely and removed P2 labels Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-VoIP O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement
Projects
None yet
Development

No branches or pull requests

4 participants