Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing-in from a room URL does not redirect to said URL when signed in #12155

Closed
nchevobbe opened this issue Jan 30, 2020 · 4 comments · Fixed by #13650
Closed

Signing-in from a room URL does not redirect to said URL when signed in #12155

nchevobbe opened this issue Jan 30, 2020 · 4 comments · Fixed by #13650

Comments

@nchevobbe
Copy link

Description

if I click the https://chat.mozilla.org/#/room/#devtools:mozilla.org URL and I don't have an account, after signing-in, I'm redirected to https://chat.mozilla.org.


I'd expect to be redirected to the room URL. It would be important for our contributors who are not used to Riot to directly arrive in the right room.

Version information

@jryans
Copy link
Collaborator

jryans commented Feb 17, 2020

Thanks for the feedback! I agree this would greatly help with onboarding new people into a specific community.

@jryans
Copy link
Collaborator

jryans commented Feb 17, 2020

I guess there's a bit of design challenge, as we currently show the "Riot Bot" user first for a new account to intro bits of Riot.

We would need to somehow also remember the room of interest as well.

@jryans
Copy link
Collaborator

jryans commented Apr 24, 2020

We have since removed Riot Bot, so this may now be easier to achieve.

@t3chguy t3chguy self-assigned this May 13, 2020
@t3chguy t3chguy added the A-SSO label May 13, 2020
@t3chguy
Copy link
Member

t3chguy commented May 13, 2020

So this issue is actually SSO specific, we don't pass the fragment as SSO callback arg.
https://github.com/matrix-org/matrix-react-sdk/blob/7e996cb91c9d6af8bfffd1782b51c6bff75075da/src/BasePlatform.js#L172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants