Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantically connect the tab list to the right side bar #11319

Closed
MarcoZehe opened this issue Nov 5, 2019 · 0 comments · Fixed by matrix-org/matrix-react-sdk#4071
Closed
Labels

Comments

@MarcoZehe
Copy link

Right now, the tab list (the div with class mx_HeaderButtons), which contains the tabs pertaining to the right side bar, is part of the main header wrapper. But semantically, it belongs to the aside that contains the side bar. It should be moved into that side bar to create a DOM-wise and screen-reader logical connection to that side bar, since from the current layout, it is not clear that these tabs affect the side bar, not the main view of the room.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants