Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show pending edits and redactions by fading the event body. #10080

Closed
lampholder opened this issue Jun 17, 2019 · 7 comments · Fixed by matrix-org/matrix-react-sdk#3117
Closed

Comments

@lampholder
Copy link
Member

For edits, the event body should reflect the new message text (and the event should be faded)

For redactions, the event body should look like it was immediately prior to the redaction.

It should be faded to look the same as a pending message send (which I think is actually implemented by styling sending messages as color: #ddd;).

There are outstanding issues around failure state UX discussed in more detail on #9692 - we'll pick these up once @nadonomy returns from holiday.

@jryans
Copy link
Collaborator

jryans commented Jun 18, 2019

This is considered a release blocker, at least for the redactions portion, to ensure that redactions clearly indicate pending and completed states.

@bwindels
Copy link
Contributor

fadededit

Edits are already fading the original message while sending FWIW

@bwindels
Copy link
Contributor

For redactions, the event body should look like it was immediately prior to the redaction.

wouldn't this just make it look broken? Or you meant the text but blended, as discussed on matrix?

@bwindels
Copy link
Contributor

Got auto-closed as in the PR I said "Fixes ...". The release-blocker part should be addressed though.

@bwindels
Copy link
Contributor

bwindels commented Jun 18, 2019

AFAIK the only remaining thing is doing a design review on what a pending redaction should look like. Currently like this:

blendedpendingredaction-dark

@jryans
Copy link
Collaborator

jryans commented Jun 18, 2019

@bwindels Hmm, so the only thing left is to improve the design? I'd say use #9692 for that and consider this one done as it seems to fix the immediate pressing issues.

@bwindels
Copy link
Contributor

Sgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants