-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show pending edits and redactions by fading the event body. #10080
Comments
This is considered a release blocker, at least for the redactions portion, to ensure that redactions clearly indicate pending and completed states. |
wouldn't this just make it look broken? Or you meant the text but blended, as discussed on matrix? |
Got auto-closed as in the PR I said "Fixes ...". The release-blocker part should be addressed though. |
Sgtm! |
For edits, the event body should reflect the new message text (and the event should be faded)
For redactions, the event body should look like it was immediately prior to the redaction.
It should be faded to look the same as a pending message send (which I think is actually implemented by styling
sending
messages ascolor: #ddd;
).There are outstanding issues around failure state UX discussed in more detail on #9692 - we'll pick these up once @nadonomy returns from holiday.
The text was updated successfully, but these errors were encountered: