Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] EX: UX Redesign of Settings > Encryption #2590

Closed
7 tasks done
mxandreas opened this issue Oct 18, 2024 · 9 comments
Closed
7 tasks done

[Story] EX: UX Redesign of Settings > Encryption #2590

mxandreas opened this issue Oct 18, 2024 · 9 comments

Comments

@mxandreas
Copy link

mxandreas commented Oct 18, 2024

Description

The UX of setting up a recovery (key) and turning OFF/ON the server-side key storage has been revisited with the main purpose is to allow the end users to make a much better sense of it.

The designs have been revisited cross-platform, both EW and EX, and it is desired that the implementation of those are not too far apart; this story only applies to EX as the starting point for EW and EX is different. EW needs to do structural changes to Settings while EX only needs to change the copy and minor visual aspects.

The scope is the Settings > Encryption (currently Chat backup) menu which has 3 scenarios from user perspective:

The sub-menu End-to-End Encryption with the functions to Export / Import Keys and Reset end-to-end encryption is currently not in scope.

Acceptance criteria

  • UI corresponds to the linked design.

Leads

Size estimate

None

Dependencies

  • None

Out of scope

  • Nothing

Open questions

Questions

Preview Give feedback
No tasks being tracked yet.

Subtasks

Android

Preview Give feedback
  1. T-Task
    bmarty
  2. T-Task
    bmarty
  3. T-Task
    bmarty

iOS

Preview Give feedback
  1. T-Task
  2. T-Task
  3. T-Task

Rust

Preview Give feedback
No tasks being tracked yet.

Other

Preview Give feedback

Sign-off

Android

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion

iOS

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion
@mxandreas
Copy link
Author

cc @manuroe

@bmarty
Copy link
Member

bmarty commented Oct 29, 2024

@mxandreas done on Android with element-hq/element-x-android#3750, can you please check the video there and confirm that it matches what you are expecting?

@americanrefugee please let me know if I missed anything. Thanks!

@americanrefugee
Copy link

I noticed one thing:
After generating/saving the recovery key and clicking "Done", the user should see this confirmation page.

@americanrefugee
Copy link

Sorry, one more thing:

After setting up the recovery key, the Settings menu item should simply say "Change recovery key" without any additional help text.

At least that's what was designed. @mxandreas do you agree?

@mxandreas
Copy link
Author

At least that's what was designed. @mxandreas do you agree?

So, the additional help text should only be removed "for a moment" after the setup. If you come back later to the Encryption settings, then the help text should be there again?

I do not mind that, but I am curious what is the reasoning for this? It is not obvious for me.

@bmarty
Copy link
Member

bmarty commented Oct 29, 2024

I noticed one thing: After generating/saving the recovery key and clicking "Done", the user should see this confirmation page.

@americanrefugee the dialog is displayed if the user does not click on the button to copy the key. See below:

NotSavingRecoveryKey.mp4

Do you want this dialog to always be displayed?

@americanrefugee
Copy link

So, the additional help text should only be removed "for a moment" after the setup. If you come back later to the Encryption settings, then the help text should be there again?

I do not mind that, but I am curious what is the reasoning for this? It is not obvious for me.

On second thought, I guess it doesn't make sense to remove the help text. I shall add it back in the design.

the dialog is displayed if the user does not click on the button to copy the key.

Ah, I forgot about that nuance. Let's keep it as you've implemented it. Sorry for the runaround!

@pixlwave
Copy link
Member

The changes are now available on the latest iOS Nightly (744).

@manuroe
Copy link
Member

manuroe commented Dec 11, 2024

The help page needs to be updated accordingly: https://element.io/help#encryption

The web page received an update.
image

I am ticking this very last taks and close this epic. Thanks everyone!

@manuroe manuroe closed this as completed Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants