Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message Editing: Change default push rules to not send notifications for edits #1312

Open
jryans opened this issue May 29, 2019 · 1 comment

Comments

@jryans
Copy link

jryans commented May 29, 2019

We should change push rules so that notifications are not sent for edits by default.

I am not exactly sure how to best accomplish that though, as it's apparently hard to change the default push rules after account creation time. Anyway, some possibilities:

  • Add a new default push rule to the spec that disables notifications for edits
  • Allow Riot to install a user push rule that disables notifications for edits

Either way, we'd like to disable edit notifications by default. We could additionally allow them to be enabled for users that want that, but that doesn't seem required for a first pass.

@jryans
Copy link
Author

jryans commented May 31, 2019

@nadonomy brought up that we should think carefully about what happens to edits that introduce a mention of someone, etc. We may want to disable notifications for "basic" edits with no other features, but still keep them for edits that add a user mention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants