-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App: UISI AutoReporting #5743
App: UISI AutoReporting #5743
Conversation
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/9psZWV |
…empts), add labs flag, increase rate limit spacing.
…eyd/5017_uisi_autoreporter
import MatrixSDK | ||
import GBDeviceInfo | ||
|
||
extension MXBugReportRestClient { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pixlwave I extracted the common common code for sending reports from the app in case it's useful for your needs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
...emplateAdvancedRoomsExample/TemplateRoomChat/Service/MatrixSDK/TemplateRoomChatService.swift
Outdated
Show resolved
Hide resolved
...wiftUI/Modules/Template/TemplateAdvancedRoomsExample/TemplateRoomChat/View/ImageViewer.swift
Outdated
Show resolved
Hide resolved
...wiftUI/Modules/Template/TemplateAdvancedRoomsExample/TemplateRoomChat/View/ImageViewer.swift
Outdated
Show resolved
Hide resolved
...wiftUI/Modules/Template/TemplateAdvancedRoomsExample/TemplateRoomChat/View/ImageViewer.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise looks good to me in terms of interoperability with web and android. I'm not clear on how most of these UI changes relate to this PR, is that separate work that accidentally got added to this branch?
).jsonString ?? "" | ||
|
||
self.bugReporter.vc_sendBugReport( | ||
description: "Auto-reporting decryption error", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing that'd be good to add here: if the description
field contains the recipient_rageshake
URL on a second line, it'll show up linkified in the github issue body so it's a lot easier to cross-reference sender and recipient rageshakes. See https://github.com/matrix-org/matrix-react-sdk/blob/develop/src/stores/AutoRageshakeStore.ts#L149
Thanks for both of the reviews, really helpful! updated based on comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Accompanies SDK PR matrix-org/matrix-ios-sdk#1386
Resolves #5017
What's in this PR
TODO
isEncrypted
but not clear event here. Open issue and fix. It's implementation could also be a bit more in line with web in just monitoring decryption attempts. Update UISI Auto-Reporting to match Web/iOS implementation element-android#5596