diff --git a/RiotSwiftUI/Modules/Room/UserSuggestion/UserSuggestionViewModel.swift b/RiotSwiftUI/Modules/Room/UserSuggestion/UserSuggestionViewModel.swift index 51a3aa7f78..da4e3fbadd 100644 --- a/RiotSwiftUI/Modules/Room/UserSuggestion/UserSuggestionViewModel.swift +++ b/RiotSwiftUI/Modules/Room/UserSuggestion/UserSuggestionViewModel.swift @@ -46,8 +46,8 @@ class UserSuggestionViewModel: UserSuggestionViewModelType, UserSuggestionViewMo super.init(initialViewState: UserSuggestionViewState(items: items)) - userSuggestionService.items.sink { items in - self.state.items = items.map({ item in + userSuggestionService.items.sink { [weak self] items in + self?.state.items = items.map({ item in UserSuggestionViewStateItem(id: item.userId, avatar: item, displayName: item.displayName) }) }.store(in: &cancellables) diff --git a/changelog.d/5058.bugfix b/changelog.d/5058.bugfix new file mode 100644 index 0000000000..c1bba11017 --- /dev/null +++ b/changelog.d/5058.bugfix @@ -0,0 +1 @@ +UserSuggestionViewModel: Fix retain cycle