1:1 call - screen sharing no longer works after pressing the cancel button

[gumara-dev]

Steps to reproduce

I start a 1:1 video call on the desktop app. Click "Start screen sharing". Then click on "Cancel" in the "Share content" dialog. Then I click on "Start screen sharing" again. Now the "Share content" dialog no longer opens. This error can only be rectified by restarting the app.

Outcome

What did you expect?

That the dialog opens again.

What happened instead?

The "Share content" dialog no longer opens. Only after restarting the app

Operating system

Windows 10 Pro 22H2

Application version

Element Desktop App: 1.11.51 Crypto version: Olm 3.2.15

How did you install the app?

No response

Homeserver

No response

Will you send logs?

No

[akoyaxd]

Same on Windows 11

[ghost]

I can reproduce this issue on Linux as well:

• Element version: 1.11.53
• Olm version: 3.2.15
• Homeserver: Synapse 1.98.0
• Installation Package: https://archlinux.org/packages/extra/x86_64/element-desktop/

[Cyberes]

Can confirm. T-Major despite being closed and ignored.

[Engineer-of-Stuff]

Why does @t3chguy keep closing these issues? It's a major issue that multiple people have confirmed.

[bblacher]

This also happens when using Element Call video rooms:

• I have this issue on Element Desktop 1.11.58 using Rust SDK 0.7.0 (691ec63) on Arch Linux (installed from the Arch repos).
• A friend of mine is having this issue on Element nightly 0.0.1-nightly.2024022701 on Windows 10 installed from https://element.io/download.

I'm willing to send logs, my friend would provide them as well, however using /rageshake is not an option because it gives us both an error when trying to submit them. (HTTP 500) I would love to send them somewhere else though. @t3chguy

[gumara-dev]

Is there anything new here?

[Cyberes]

T-wontfix

[t3chguy]

@Cyberes its open source. Have at it. Its in a rather large pile of issues and it takes quite a while for something to make it onto the roadmap which is planned many months in advance.

[bblacher]

@t3chguy Kind of off-topic, but is the roadmap public?

[t3chguy]

I don't believe it is anymore - https://github.com/element-hq/roadmap/projects/1 is closed for whatever reason and https://element.io/blog/announcing-the-element-public-roadmap/ is just stale

[bblacher]

Alright, thanks :)

[gumara-dev]

Found the problem.

With Cancel, the call in ElectronPlatform.tsx is returned in line 173.
However, the await function that was called by the matrix-js-sdk call.ts on line 1086 never returns. This only happens when a stream is selected.
If this return is now commented out and the this.ipc.call("callDisplayMediaCallback", source); is also executed on cancel, it works. However, an error still occurs here.
This should be caught with a try and catch block in the ipc.ts file.
E.g. case "callDisplayMediaCallback": try { await getDisplayMediaCallback()?.({ video: args[0] }); } catch (e) {} setDisplayMediaCallback(null); ret = null; break;

[bblacher]

@gumara-dev It would be great if you could open a PR with those changes, I'm sure they'd review it.

[gumara-dev]

@gumara-dev It would be great if you could open a PR with those changes, I'm sure they'd review it.

Thanks for the comment, I found a quite simpler solution.