Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build cache misses #7157

Merged
merged 2 commits into from
Sep 16, 2022
Merged

Fix build cache misses #7157

merged 2 commits into from
Sep 16, 2022

Conversation

ouchadam
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Forcing the stem string template generator tasks to be cachable, without this the templates are regenerated causing the vector module to recompile its sources (our slowest task!)

Motivation and context

The build cache was enabled by default with #6788 but the vector module was getting constant cache misses when the library/ui-strings executed it's generator tasks

Screenshots / GIFs

N/A

Tests

Compile the project twice (on a branch other than develop)

./gradlew clean assembleGplayDebug // 3 minutes
./gradlew clean assembleGplayDebug // 18 seconds

Tested devices

N/A

- forcing the stem string template generator to be cachable, without this the templates are regenerated causing the vector module to recompile its sources (our slowest task!)
@ouchadam ouchadam added the PR-Small PR with less than 20 updated lines label Sep 16, 2022
@ouchadam ouchadam requested review from a team and bmarty and removed request for a team September 16, 2022 14:04
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ouchadam ouchadam merged commit 9a298a6 into develop Sep 16, 2022
@ouchadam ouchadam deleted the feature/adm/cache-misses branch September 16, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Small PR with less than 20 updated lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants