Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encrypted rooms often show red shield despite all sessions trusted & users verified #8046

Closed
krassle opened this issue Jan 31, 2023 · 12 comments
Closed

Encrypted rooms often show red shield despite all sessions trusted & users verified #8046

krassle opened this issue Jan 31, 2023 · 12 comments
Assignees
@yostyle
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Team: Crypto X-Cannot-Reproduce

Comments

@krassle
Copy link

krassle commented Jan 31, 2023 •
edited by yostyle
Loading

Steps to reproduce

  1. Be in an e2ee room with 3+ people, where all participants are verified and their sessions trusted
  2. Observe small red shield icon next to room avatar
  3. Verify all participants have no untrusted sessions
  4. Navigate to Settings -› Security & Privacy -› Active Sessions -› Show All Sessions
  5. Then go back to room and observe: red shield icon changed to green with a checkmark!

[1/6]

[2/6]

[3/6]

[4/6]

[5/6]

[6/6]

This bug exists since at least v.1.5.18, but does not affect Element-Web or Desktop.

Outcome

What did you expect?

No random status change of e2e encrypted rooms (verified/trusted->unverified/untrusted)

What happened instead?

Red shield icon despite all users verified and their sessions trusted and trusted/verified Green shield icon shown only after manual intervention

Your phone model

HUAWEI LLD-L31

Operating system version

Android 9

Application version and app store

Element version 1.5.22 [40105222] (G-bdd431d2), olm version 3.2.12 from Google Play Store

Homeserver

Synapse 1.73

Will you send logs?

No

Are you willing to provide a PR?

No
@krassle krassle added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Jan 31, 2023
@jonnyandrew jonnyandrew added X-Cannot-Reproduce S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience Team: Crypto labels Feb 7, 2023
@TheCycoONE
Copy link

TheCycoONE commented Feb 17, 2023 •
edited by yostyle
Loading

I just hit something like this. The room had a red shield and the people view had a red shield on me but all my sessions were trusted. Went away on restarting the app.

@yostyle yostyle self-assigned this Feb 17, 2023
@yostyle
Copy link
Contributor

yostyle commented Feb 21, 2023 •
edited
Loading

In this screen the shield at the left of the username is green if all devices are verified by cross signing only otherwise the shield is red (or black if the current session is not verified).

The shields in the security section are green if all devices are verified locally or by cross signing.

So the state of your screenshot is possible if you verify a session without cross signing or if the current session state is not refreshed properly after a verification by cross signing.

I can't reproduce this issue and I need to investigate more time to understand what's happen.

@krassle
Copy link
Author

krassle commented Feb 21, 2023

@yostyle

So the state of your screenshot is possible if you verify a session without cross signing or if the current session state is not refreshed properly after a verification by cross signing.

My observation(as a hint):
The state changes from red to green (screen [2/6] --›› [6/6]) immediately after viewing Show All Sessions (Settings -› Security & Privacy -› Active Sessions -› Show All Sessions). So probably, as you suggested, it is not properly refreshed (or read from cache or something) on every app startup, therefore appears randomly and is also mitigated by an app restart as mentioned by @TheCycoONE.

But I don't think this state should be possible(intentional or valid) at all, as it'd be extremely confusing showing a verified user with all trusted sessions, but with an alarming red shield next to the username. What is the issue then and where is the distinction? 😕

I can't reproduce this issue and I need to investigate more time to understand what's happen.

Thank you for taking the time to look into this, it is very much appreciated. 👍 😉

Please let me also know if I can help in any other way, as on my side this issue is almost always reproducible (on every second or third run of the app). So far I've tried clearing the cache (Settings -› General -› Advanced -› Clear cache) but without success...

@TheCycoONE
Copy link

I saw the red shield on the room again today, and again looking at the list of users it was on me. I had not added any new sessions since last time and again it went green on restart.

@Gitogitos
Copy link

Gitogitos commented Mar 1, 2023 •
edited
Loading

Have exactly the same, all my sessions are verified, trusted but when click on my user I got red shield. Cross signing is activated the same. My version of Element is 1.5.22 [4010522] (G-bdd431d2), This could be related to that but it’s strange cause she is verified as well on every session.
Screenshot_20230301-140508
Screenshot_20230301-140646

@yostyle yostyle mentioned this issue Mar 2, 2023
Merged
@giomfo
Copy link
Member

giomfo commented Mar 22, 2023

I will close this issue because the context has changed since PR #8195. Indeed the room member shields should be coherent in the different screen.
This change has been released in v1.5.28

Please create a new issue if you still observe a persistent unexpected red shields. Logs (Rageshakes) would be then very useful.

@giomfo giomfo closed this as completed Mar 22, 2023
@krassle
Copy link
Author

krassle commented Mar 31, 2023

Still not fixed in v1.5.28. Rageshake sent.

@yostyle
Copy link
Contributor

yostyle commented Apr 4, 2023 •
edited
Loading

@krassle do you have the same result in room member screen ? it shouldn't.

@krassle
Copy link
Author

krassle commented Apr 4, 2023

@yostyle The only thing that's changed is the Label under Security. Now it says Warning instead of previously Verified (2/2).

1/2
photostudio_1680628294457

2/2
photostudio_1680629182868

@giomfo giomfo mentioned this issue Apr 5, 2023
Closed
@giomfo
Copy link
Member

giomfo commented Apr 5, 2023

@krassle thanks for your new screenshots
FYI I created a new issue, I will ask to the crypto team to work on it

@BillCarsonFr
Copy link
Member

@krassle if you can reproduce can you go the Settings > Advanced Settings > Enable verbose logs and send a new RS

@krassle
Copy link
Author

krassle commented Jun 5, 2023 •
edited
Loading

@BillCarsonFr
I can still reproduce it. Rageshake sent, linked it to the new issue #8308
Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yostyle yostyle

Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Team: Crypto X-Cannot-Reproduce
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@TheCycoONE @yostyle @jonnyandrew @krassle @giomfo @BillCarsonFr @Gitogitos