Replace calls to launchWhenResumed with repeatOnLifecycle

[bmarty]

launchWhenResumed is not recommended and will be removed in the future.
We should instead use repeatOnLifecycle

Exemple:

 lifecycleScope.launch {
                lifecycle.repeatOnLifecycle(Lifecycle.State.RESUMED) {
                    flow.collect { flowItem ->
                        //DoSomethingWithFlowItem(flowItem
                    }
                }
            }

We might also be safer with listening viewEvents flow from ViewModel, to avoid refreshing UI if the app is in background:
So replace:

viewEvents
                .stream()
                .onEach {
                    hideWaitingView()
                    observer(it)
                }
                .launchIn(lifecycleScope)

By:

lifecycleScope.launch { 
            repeatOnLifecycle(Lifecycle.State.RESUMED){
                viewEvents.stream()
                        .collect {
                            hideWaitingView()
                            observer(it)
                        }
            }
        }