Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Space Switching: Spaces Bottom Sheet Should Have Expandable Subspaces #6815

Closed
Tracked by #6605
daniellekirkwood opened this issue Aug 11, 2022 · 3 comments · Fixed by #6907
Closed
Tracked by #6605

Space Switching: Spaces Bottom Sheet Should Have Expandable Subspaces #6815

daniellekirkwood opened this issue Aug 11, 2022 · 3 comments · Fixed by #6907
Assignees
@ericdecanini
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-AppLayout

Comments

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Aug 11, 2022 •
edited by ericdecanini
Loading

Initially we aimed for an approach where clicking on a space closed the bottom sheet and you'd have to open the sheet again if you want to navigate even deeper.

Following internal and community feedback, we want to revert to the old style of having expandable subspaces.

Figma link:
https://www.figma.com/file/Hw4gjP3pknMZUir8jQqmWH/%5BMobile%5D-IA-early-proposals
@daniellekirkwood daniellekirkwood added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Needs-Design May require input from the design team Z-AppLayout labels Aug 11, 2022
@daniellekirkwood
Copy link
Contributor Author

can't access all chats from inside a space when that space has subspaces

@daniellekirkwood daniellekirkwood changed the title App Layout: Bottom Sheet App Layout: Spaces switching bottom sheet Aug 11, 2022
@daniellekirkwood
Copy link
Contributor Author

@amshakal @ericdecanini Let's chat about the behaviour of the space switching sheet :D

@ericdecanini ericdecanini changed the title App Layout: Spaces switching bottom sheet App Layout: Spaces Bottom Sheet Should Have Expandable Subspaces Aug 17, 2022
@ericdecanini
Copy link
Contributor

I'm relabelling this issue as an enhancement. We have the other defects already written separately here
#6605

@ericdecanini ericdecanini mentioned this issue Aug 17, 2022
Closed
27 tasks
@ericdecanini ericdecanini changed the title App Layout: Spaces Bottom Sheet Should Have Expandable Subspaces Space Switching: Spaces Bottom Sheet Should Have Expandable Subspaces Aug 17, 2022
@amshakal amshakal removed the X-Needs-Design May require input from the design team label Aug 17, 2022
@amshakal amshakal removed their assignment Aug 17, 2022
@ericdecanini ericdecanini mentioned this issue Aug 22, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericdecanini ericdecanini

Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-AppLayout
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Space Switching: Accordion-Style Bottom Sheet element-hq/element-android
3 participants
@ericdecanini @amshakal @daniellekirkwood