Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space Switching: Should Scrolling Make FAB Dissapear? #6767

Closed
Tracked by #6605
germain-gg opened this issue Aug 8, 2022 · 7 comments
Closed
Tracked by #6605

Space Switching: Should Scrolling Make FAB Dissapear? #6767

germain-gg opened this issue Aug 8, 2022 · 7 comments
Assignees
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-AppLayout

Comments

@germain-gg
Copy link
Contributor

Steps to reproduce

  1. Make sure you're scrolled up to the top of the list
  2. Scroll up using one finger

Outcome

What did you expect?

For the FAB to always be visible

What happened instead?

The FAB dissapear for the duration of the finger interaction with the screen

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

No

@germain-gg germain-gg added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-AppLayout labels Aug 8, 2022
@ericdecanini
Copy link
Contributor

ericdecanini commented Aug 9, 2022

This is already the case with the current Element app in prod. I've checked this with other apps and it's not standard behaviour across Android.

@daniellekirkwood @amshakal do we want to change this behaviour?

@amshakal
Copy link

amshakal commented Aug 9, 2022

We should follow the standrard Android behavior in such scenarios.

@daniellekirkwood
Copy link
Contributor

So the standard behaviour in Android is that the FAB is always visible? Regardless whether the user is scrolling or not?

@ericdecanini
Copy link
Contributor

Some very little research I did with a couple of apps from google showed me this behaviour, but I think we need a little more research to say for sure. I could be wrong

@ericdecanini ericdecanini changed the title Scrolling up when at the top of the list make FAB dissapear Space Switching? Should Scrolling Make FAB Dissapear? Aug 17, 2022
@ericdecanini
Copy link
Contributor

I've relabled this issue as a question as we need some investigation on the desired behaviour

@ericdecanini ericdecanini changed the title Space Switching? Should Scrolling Make FAB Dissapear? Space Switching: Should Scrolling Make FAB Dissapear? Aug 17, 2022
@amshakal
Copy link

According to material 3, on scrolling FAB should be visible still: https://m3.material.io/components/floating-action-button/guidelines. We should stick to native behavior. We can change it later if needed

@ericdecanini
Copy link
Contributor

Thanks for looking into this @amshakal! I'll close this issue following that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-AppLayout
Projects
None yet
Development

No branches or pull requests

4 participants