Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write Unit Tests for Space List #6484

Open
Tracked by #6605
ericdecanini opened this issue Jul 6, 2022 · 2 comments
Open
Tracked by #6605

Write Unit Tests for Space List #6484

ericdecanini opened this issue Jul 6, 2022 · 2 comments
Assignees
@fedrunov
Labels
A-Spaces Spaces, groups, communities T-Task Refactoring, enabling or disabling functionality, other engineering tasks Team: Delight Z-AppLayout Z-Tests

Comments

@ericdecanini
Copy link
Contributor

We want to refactor code for testability and add unit tests for them in areas relevant to the space list, its retrieval and usages. This is preparation for the space switching implementation and also to push towards the goal of getting more test coverage around the app
@ericdecanini ericdecanini added Z-Tests A-Spaces Spaces, groups, communities T-Task Refactoring, enabling or disabling functionality, other engineering tasks Team: Delight labels Jul 6, 2022
@ericdecanini ericdecanini self-assigned this Jul 6, 2022
@ericdecanini ericdecanini mentioned this issue Jul 6, 2022
Closed
@ericdecanini ericdecanini changed the title Write unit tests for space list Write Unit Tests for Space List Jul 7, 2022
@ericdecanini ericdecanini mentioned this issue Jul 20, 2022
Closed
27 tasks
@ericdecanini ericdecanini mentioned this issue Sep 20, 2022
Closed
15 tasks
@germain-gg germain-gg assigned fedrunov and unassigned ericdecanini Oct 31, 2022
@germain-gg
Copy link
Contributor

@fedrunov it looks like a PR has been open but has not been merged. Could you take a look and see whether we can merge it or not?

@ericdecanini
Copy link
Contributor Author

@fedrunov please reopen this as

@ericdecanini ericdecanini reopened this Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fedrunov fedrunov

Labels
A-Spaces Spaces, groups, communities T-Task Refactoring, enabling or disabling functionality, other engineering tasks Team: Delight Z-AppLayout Z-Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds Space List Unit Tests element-hq/element-android
3 participants
@germain-gg @ericdecanini @fedrunov