Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for emoji 14.0 #5876

Closed
thanasistrisp opened this issue Apr 30, 2022 · 5 comments
Closed

Add support for emoji 14.0 #5876

thanasistrisp opened this issue Apr 30, 2022 · 5 comments
Labels
A-Emoji Picker A-Emoji O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@thanasistrisp
Copy link

Your use case

What would you like to do?

Support emoji 14.0

Why would you like to do it?

So that people can use the latest and greatest emoji.

How would you like to achieve it?

By updating our Twemoji and Emojibase sources. In element web it is already implemented here

Have you considered any alternatives?

No response

Additional context

No response

@thanasistrisp thanasistrisp added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Apr 30, 2022
@ouchadam
Copy link
Contributor

ouchadam commented May 4, 2022

it looks like the emoji-compat library we're using has included support for emoji14 in the 1.1.0 release https://developer.android.com/jetpack/androidx/releases/emoji2#1.1.0

@thanasistrisp
Copy link
Author

it looks like the emoji-compat library we're using has included support for emoji14 in the 1.1.0 release https://developer.android.com/jetpack/androidx/releases/emoji2#1.1.0

I do not think so! I have version 1.4.13 installed and it is not available in emoji picker. However, if I send it through another device (e.g. Android 12) it displays correctly in a device that does not support Unicode 14.0

@ouchadam
Copy link
Contributor

ouchadam commented May 4, 2022

my bad, I should have stated that we also need to include the updated version in Element (am raising a PR to do the update)

@ouchadam
Copy link
Contributor

ouchadam commented May 4, 2022

we'll need to wait for vanniktech/Emoji#691 to also be released

@ericdecanini ericdecanini added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Sep 7, 2022
@jmartinesp
Copy link
Member

I believe this is already done, as the referenced PR is merged and I could use some of the new emojis without issues. Please re-open it otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Emoji Picker A-Emoji O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

No branches or pull requests

4 participants