-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Element doesn't respect system font scaling #5687
Comments
We have currently app-wide setting to define font scale (Settings->Preferences->Font size) and the problem is that on app start we always set font scale for the app from that setting. So if system setting is the "largest" text scale but in-app setting is "normal", the resulting applying scale will be "normal", and if user change system setting we ignore it, applying only whatever set in the app settings. The only moment when we sync with system property is first start of the app.- we get system property and apply it to the app setting. I think we should have "system default" setting as default one, until user manually change it to something specific in the app settings. If "system default" is set, app will use system settings, reflecting any changes in them. @daniellekirkwood what do you think? |
Thanks, @fedrunov !! Let's go ahead and add "Use system default" to the top of this list with a radio button. We'll use font size "Normal" for the label. |
Here how it looks like: I think it would be better if list will contain only scale factor items and "use system default" will be on top as a checkbox. When it's checked list will be "readonly" and item, corresponding to system setting will be selected. When it's unchecked list will be interactive and user could select an option to override system setting for element. |
@niquewoodhouse, @amshakal what do you think? |
Hey! I agree with your solution, the only thing I'll add is a line seperating system default from the rest of the options. Happy to create a visual representation of it if needed. |
@amshakal thanks, I think it would be better if we'll have design in figma. I also think that this should be a full screen, since list doesn't fit dialog anymore and scroll in dialog is not a perfect solution |
I have created a full screen interaction to choose font size. I have kept system default as a separate option, and when selected, the options below will be disabled. Let me know if this works. Figma link. |
Steps to reproduce
Outcome
Font sizes don't change
Your phone model
No response
Operating system version
No response
Application version and app store
No response
Homeserver
No response
Will you send logs?
No
The text was updated successfully, but these errors were encountered: