Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when viewing source which contains an emoji #4796

Closed
ouchadam opened this issue Dec 22, 2021 · 1 comment
Closed

Crash when viewing source which contains an emoji #4796

ouchadam opened this issue Dec 22, 2021 · 1 comment
Assignees
@bmarty
Labels
A-devtools A-Emoji A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@ouchadam
Copy link
Contributor

Steps to reproduce

  1. Enable the settings option - developer mode
  2. open or submit to an unencrypted room the 😮‍💨 emoji
  3. View source of the message containing the emoji

Outcome

What did you expect?

No crash!

What happened instead?

App crashes due to https://github.com/BillCarsonFr/JsonViewer/blob/master/jsonviewer/src/main/java/org/billcarsonfr/jsonviewer/ValueItem.kt#L20 needing to apply the emoji fix #4698

Thread: main, Exception: com.airbnb.epoxy.ImmutableModelException: The model was changed during the bind call. Position: 5 Model: ValueItem_{text="displayname" : "😮‍💨",...

at com.airbnb.epoxy.EpoxyModel.validateStateHasNotChangedSinceAdded(EpoxyModel.java:3)
at org.billcarsonfr.jsonviewer.ValueItem_.handlePostBind(ValueItem_.java:2)
at com.airbnb.epoxy.BaseEpoxyAdapter.onBindViewHolder(BaseEpoxyAdapter.java:27)
at com.airbnb.epoxy.BaseEpoxyAdapter.onBindViewHolder(BaseEpoxyAdapter.java:3)
at androidx.recyclerview.widget.RecyclerView$Adapter.bindViewHolder(RecyclerView.java:9)

https://github.com/matrix-org/element-android-rageshakes/issues/30406
https://github.com/matrix-org/element-android-rageshakes/issues/30378

Your phone model

No response

Operating system version

android 10 (MIUI 12.0.3.0)

Application version and app store

1.3.12

Homeserver

No response

Will you send logs?

No
@ouchadam ouchadam added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Emoji A-Timeline S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow A-devtools labels Dec 22, 2021
@bmarty bmarty assigned bmarty and unassigned BillCarsonFr Jan 5, 2022
@bmarty bmarty mentioned this issue Jan 18, 2022
Closed
37 tasks
@bmarty
Copy link
Member

bmarty commented Jan 20, 2022

Fixed in 1.3.15

@bmarty bmarty closed this as completed Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

Labels
A-devtools A-Emoji A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ouchadam @bmarty @BillCarsonFr