Feature/fga/dial pad improvements #3516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganfra
force-pushed
the
feature/fga/dial_pad_improvements
branch
from
9f24d39 to
b6f80cb
Compare
bmarty
approved these changes
Jun 16, 2021
vector/src/main/java/im/vector/app/features/call/dialpad/DialPadFragment.kt
Outdated
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/call/dialpad/DialPadFragment.kt
Outdated
Show resolved
Hide resolved
ganfra
force-pushed
the
feature/fga/dial_pad_improvements
branch
from
b6f80cb to
487b97c
Compare
bmarty
reviewed
Jun 17, 2021
| val number = PhoneNumberUtils.formatNumber(networkPortion, null, regionCode) ?: networkPortion | ||
| // Also retrieve the post dial portion of the provided data, so that the entire dial string can be reconstituted | ||
| val postDial = PhoneNumberUtils.extractPostDialPortion(dialString) | ||
| return if (postDial.isEmpty()) { |
There was a problem hiding this comment.
Can't you just return number + postDial? Should be ok if postDial is empty, no?
ganfra
force-pushed
the
feature/fga/dial_pad_improvements
branch
from
487b97c to
1bb32ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles:
Enabling cursor, so you can add/remove digits everywhere.
Fixing the formatting as you type
Adding paste number when clicking on ok button if EditText is empty (mimics Android DialPad)