Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully support Android 11 Conversations #1722

Open
5 tasks
dkter opened this issue Jul 18, 2020 · 4 comments
Open
5 tasks

Fully support Android 11 Conversations #1722

dkter opened this issue Jul 18, 2020 · 4 comments

Comments

@dkter
Copy link
Contributor

dkter commented Jul 18, 2020

It seems like there are a few things that need to be done to fully support Android 11's new Conversations interface:

  • Enable conversation-specific features (priority conversations, per-contact ringtones, etc), as described in the relevant documentation, by associating the notifications with a long-lived shortcut. (I think Element is currently in the "MessagingStyle is used but no shortcut is provided" stage)
  • Crop room icons into a circle. As of now, room icons are square in Conversation notifications while user icons are circular, which looks a bit weird especially since room icons are circular in the app
  • Ungroup separate chat notifications. It seems from this sample screenshot from the docs that the Android people ideally want ungrouped notifications:

    Not to mention it looks a lot better when they're not grouped. Here are some examples of what Element/RiotX notifications actually look like on Android 11:



    (the last two are from an older version, but the notification style hasn't changed at all since then)
    It might make sense to carry this down to older Android versions too. I don't see why notifications from separate rooms need to be grouped together; many other messaging platforms don't do this.
  • As of now, when I have Element/RiotX notifications from multiple rooms and I click on one, the grouped notification stays the same and doesn't dismiss the notification from the room I clicked on until I view the unread messages from all rooms. (this might be fixed by items 1 and/or 3 in this list - I have no idea but it seems likely)
  • Support bubbles (Bubbles API support #1124)
@dkter
Copy link
Contributor Author

dkter commented Jul 24, 2020

re: the second item - it looks like room and person icons aren't being cropped before being shown in the notification. Android crops them for us, but it means (it looks like) priority notification icons are being shown in the status bar without any crop at all. (Android 11 is still in beta so I don't know if the icons will get automatically cropped in the future)

@dkter
Copy link
Contributor Author

dkter commented Aug 6, 2020

As of Beta 3 icons are cropped into a circle automatically (except the behaviour is weird with non-square icons -- probably just a temporary Android bug). Looks like 2 can be disregarded then.

(edit -- interestingly enough, icons are cropped into a circle only with full conversation features, i.e. on my fork but not develop.)

@lindhe
Copy link
Contributor

lindhe commented Feb 16, 2022

Really looking forward to this one. Do we have an ETA?

@AmineI
Copy link

AmineI commented Apr 4, 2023

Reading around it seems like the first task has been done (priority conversations, ..) in #1809 and/or #3313, but it does not seem supported at the moment (checked on two phones, latest release, latest debug)
Am I just misundersanding the progress for this task, or should I continue searching for (and filing) a potential regression since then ?

EDIT : Looked a bit more into this - it looks like it is actually an OS regression on Samsung's flavor of Android. It seems to work fine on a Google Pixel device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants