Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice & Video device settings #1688

Closed
rajil opened this issue Jul 14, 2020 · 6 comments
Closed

Voice & Video device settings #1688

rajil opened this issue Jul 14, 2020 · 6 comments
Labels
Milestone

Comments

@rajil
Copy link

rajil commented Jul 14, 2020

The voice and video settings should allow defining the default audio device (bluetooth/ear piece/Speaker phone).

image

This will help in closing #1644.

@violoncelloCH
Copy link

violoncelloCH commented Jul 14, 2020

Why is this needed? Isn't it better to have a sane default? As:
Audiocall:

  • ear piece
  • if bluetooth (or any other) headset connected -> headset
  • or if manually switched to speakers -> speakers (including bluetooth or external ones)

Video:

  • Same but just never use the earpiece in this case, so speakers by default, and if connected the external one

I think having a Setting option for this is just unneeded overhead...

@rajil
Copy link
Author

rajil commented Jul 14, 2020

See the bug report linked above. The Bluetooth headset detection is buggy in the app. Riot thinks there is headset connected when there isn't.
With configuration options, the user is given the opportunity to sort things out. This is also what riot-web does.

@violoncelloCH
Copy link

Well no, if this headset detection is buggy (in the alpha state of the implementation), then the fix is rather to solve this problem than to add unnecessary settings... Sorry I don't get the point here why you think a setting would be absolutely needed...

@rodolpheh
Copy link

Isn't this menu supposed to add TURN server settings and video mirroring like in Element Web/Desktop as well ?

@meyerrj
Copy link

meyerrj commented Jul 22, 2020

I've noticed with video calls, it tends to default to the normal phone speakers and not as a speakerphone. This can be a bit annoying once a video chat is initiated as we have to toggle the speaker to hear each other.

@bmarty
Copy link
Member

bmarty commented Sep 14, 2020

We agree with @violoncelloCH : default audio device should depend on the current state of the phone (including proximity sensor), and its accessories (wired headset, Bluetooth devices, etc.).

@bmarty bmarty closed this as completed Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants