From bb959b6b1e63bc49e5398efb75132a3803aca07d Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Tue, 7 Dec 2021 17:10:41 +0100 Subject: [PATCH] Use viewBindingIgnore="true" when we do not need the ViewBinding. --- vector/src/debug/res/layout/item_sas_emoji.xml | 3 ++- vector/src/main/res/layout/grid_item_emoji.xml | 3 ++- vector/src/main/res/layout/grid_section_header.xml | 3 ++- .../src/main/res/layout/item_attachment_big_preview.xml | 3 ++- .../res/layout/item_attachment_miniature_preview.xml | 3 ++- vector/src/main/res/layout/item_autocomplete_command.xml | 3 ++- vector/src/main/res/layout/item_autocomplete_emoji.xml | 3 ++- .../main/res/layout/item_autocomplete_matrix_item.xml | 3 ++- .../main/res/layout/item_autocomplete_more_result.xml | 4 +++- vector/src/main/res/layout/item_bottom_sheet_action.xml | 3 ++- .../res/layout/item_bottom_sheet_joinrule_restricted.xml | 5 +++-- .../res/layout/item_bottom_sheet_message_preview.xml | 3 ++- .../main/res/layout/item_bottom_sheet_message_status.xml | 3 ++- .../main/res/layout/item_bottom_sheet_quick_reaction.xml | 3 ++- vector/src/main/res/layout/item_bottom_sheet_radio.xml | 3 ++- .../main/res/layout/item_bottom_sheet_room_preview.xml | 3 ++- vector/src/main/res/layout/item_bottom_sheet_title.xml | 3 ++- vector/src/main/res/layout/item_breadcrumbs.xml | 3 ++- vector/src/main/res/layout/item_checkbox.xml | 3 ++- .../src/main/res/layout/item_completion_homeserver.xml | 3 ++- vector/src/main/res/layout/item_contact_action.xml | 3 ++- vector/src/main/res/layout/item_contact_detail.xml | 3 ++- vector/src/main/res/layout/item_contact_main.xml | 3 ++- .../src/main/res/layout/item_create_direct_room_user.xml | 3 ++- vector/src/main/res/layout/item_device.xml | 3 ++- vector/src/main/res/layout/item_discovery_policy.xml | 3 ++- vector/src/main/res/layout/item_display_read_receipt.xml | 3 ++- vector/src/main/res/layout/item_divider.xml | 3 ++- vector/src/main/res/layout/item_divider_on_surface.xml | 3 ++- vector/src/main/res/layout/item_editable_avatar.xml | 3 ++- .../src/main/res/layout/item_editable_square_avatar.xml | 3 ++- vector/src/main/res/layout/item_emoji_result.xml | 3 ++- vector/src/main/res/layout/item_error_retry.xml | 3 ++- vector/src/main/res/layout/item_expandable_textview.xml | 3 ++- vector/src/main/res/layout/item_form_advanced_toggle.xml | 3 ++- .../main/res/layout/item_form_multiline_text_input.xml | 3 ++- vector/src/main/res/layout/item_form_submit_button.xml | 3 ++- vector/src/main/res/layout/item_form_switch.xml | 3 ++- vector/src/main/res/layout/item_form_text_input.xml | 3 ++- .../main/res/layout/item_form_text_input_with_button.xml | 3 ++- .../main/res/layout/item_form_text_input_with_delete.xml | 3 ++- vector/src/main/res/layout/item_generic_button.xml | 3 ++- vector/src/main/res/layout/item_generic_empty_state.xml | 3 ++- vector/src/main/res/layout/item_generic_footer.xml | 3 ++- vector/src/main/res/layout/item_generic_header.xml | 3 ++- vector/src/main/res/layout/item_generic_list.xml | 3 ++- vector/src/main/res/layout/item_generic_loader.xml | 4 +++- vector/src/main/res/layout/item_generic_pill_footer.xml | 3 ++- vector/src/main/res/layout/item_generic_progress.xml | 3 ++- vector/src/main/res/layout/item_generic_with_value.xml | 3 ++- vector/src/main/res/layout/item_group.xml | 5 +++-- vector/src/main/res/layout/item_help_footer.xml | 3 ++- vector/src/main/res/layout/item_invite_by_mail.xml | 3 ++- .../layout/item_keys_backup_settings_button_footer.xml | 3 ++- vector/src/main/res/layout/item_known_user.xml | 3 ++- vector/src/main/res/layout/item_loading.xml | 3 ++- vector/src/main/res/layout/item_loading_square.xml | 4 +++- vector/src/main/res/layout/item_locale.xml | 3 ++- .../src/main/res/layout/item_login_centered_button.xml | 3 ++- vector/src/main/res/layout/item_login_error_retry.xml | 3 ++- vector/src/main/res/layout/item_login_header.xml | 4 +++- vector/src/main/res/layout/item_login_password_form.xml | 3 ++- vector/src/main/res/layout/item_login_red_button.xml | 3 ++- vector/src/main/res/layout/item_login_text.xml | 3 ++- vector/src/main/res/layout/item_login_title.xml | 3 ++- vector/src/main/res/layout/item_login_title_small.xml | 3 ++- vector/src/main/res/layout/item_no_result.xml | 4 +++- vector/src/main/res/layout/item_notifications_footer.xml | 5 +++-- vector/src/main/res/layout/item_policy.xml | 3 ++- vector/src/main/res/layout/item_positive_button.xml | 3 ++- vector/src/main/res/layout/item_profile_action.xml | 3 ++- vector/src/main/res/layout/item_profile_matrix_item.xml | 6 +++--- .../res/layout/item_profile_matrix_item_progress.xml | 3 ++- vector/src/main/res/layout/item_profile_section.xml | 3 ++- vector/src/main/res/layout/item_public_room.xml | 3 ++- vector/src/main/res/layout/item_pushgateway.xml | 3 ++- vector/src/main/res/layout/item_pushrule_raw.xml | 3 ++- vector/src/main/res/layout/item_radio.xml | 7 ++++--- vector/src/main/res/layout/item_room.xml | 3 ++- vector/src/main/res/layout/item_room_directory.xml | 3 ++- .../src/main/res/layout/item_room_directory_server.xml | 3 ++- vector/src/main/res/layout/item_room_filter_footer.xml | 3 ++- vector/src/main/res/layout/item_room_invitation.xml | 3 ++- vector/src/main/res/layout/item_room_placeholder.xml | 3 ++- vector/src/main/res/layout/item_room_to_add_in_space.xml | 3 ++- .../res/layout/item_room_to_add_in_space_placeholder.xml | 4 +++- .../src/main/res/layout/item_room_to_manage_in_space.xml | 3 ++- vector/src/main/res/layout/item_room_widget.xml | 3 ++- vector/src/main/res/layout/item_search_result.xml | 3 ++- vector/src/main/res/layout/item_settings_button.xml | 3 ++- .../main/res/layout/item_settings_button_single_line.xml | 3 ++- .../src/main/res/layout/item_settings_centered_image.xml | 3 ++- .../main/res/layout/item_settings_continue_cancel.xml | 4 +++- vector/src/main/res/layout/item_settings_edit_text.xml | 3 ++- vector/src/main/res/layout/item_settings_helper_info.xml | 3 ++- vector/src/main/res/layout/item_settings_information.xml | 3 ++- vector/src/main/res/layout/item_settings_progress.xml | 4 +++- .../src/main/res/layout/item_settings_section_title.xml | 3 ++- vector/src/main/res/layout/item_settings_simple_item.xml | 3 ++- vector/src/main/res/layout/item_settings_three_pid.xml | 3 ++- vector/src/main/res/layout/item_simple_reaction_info.xml | 3 ++- vector/src/main/res/layout/item_space.xml | 5 +++-- vector/src/main/res/layout/item_space_add.xml | 4 +++- vector/src/main/res/layout/item_space_beta_header.xml | 4 +++- vector/src/main/res/layout/item_space_roomchild.xml | 3 ++- vector/src/main/res/layout/item_space_subspace.xml | 3 ++- vector/src/main/res/layout/item_space_tab.xml | 4 +++- vector/src/main/res/layout/item_space_top_summary.xml | 3 ++- vector/src/main/res/layout/item_sub_space.xml | 5 +++-- vector/src/main/res/layout/item_suggested_room.xml | 3 ++- vector/src/main/res/layout/item_text_header.xml | 3 ++- vector/src/main/res/layout/item_timeline_empty.xml | 4 +++- vector/src/main/res/layout/item_timeline_event_base.xml | 3 ++- .../main/res/layout/item_timeline_event_base_noinfo.xml | 3 ++- .../main/res/layout/item_timeline_event_base_state.xml | 3 ++- .../main/res/layout/item_timeline_event_blank_stub.xml | 4 +++- .../res/layout/item_timeline_event_call_tile_stub.xml | 9 +++++---- .../res/layout/item_timeline_event_code_block_stub.xml | 4 +++- .../src/main/res/layout/item_timeline_event_create.xml | 3 ++- .../res/layout/item_timeline_event_day_separator.xml | 3 ++- .../main/res/layout/item_timeline_event_default_stub.xml | 3 ++- .../main/res/layout/item_timeline_event_file_stub.xml | 3 ++- .../layout/item_timeline_event_media_message_stub.xml | 3 ++- .../layout/item_timeline_event_merged_header_stub.xml | 3 ++- .../item_timeline_event_merged_room_creation_stub.xml | 3 ++- .../res/layout/item_timeline_event_merged_utd_stub.xml | 3 ++- .../main/res/layout/item_timeline_event_notice_stub.xml | 3 ++- .../layout/item_timeline_event_option_buttons_stub.xml | 3 ++- .../main/res/layout/item_timeline_event_poll_stub.xml | 3 ++- .../res/layout/item_timeline_event_read_receipts.xml | 4 +++- .../res/layout/item_timeline_event_redacted_stub.xml | 4 +++- .../res/layout/item_timeline_event_status_tile_stub.xml | 3 ++- .../res/layout/item_timeline_event_text_message_stub.xml | 3 ++- .../res/layout/item_timeline_event_verification_stub.xml | 3 ++- .../main/res/layout/item_timeline_event_voice_stub.xml | 3 ++- .../main/res/layout/item_timeline_event_widget_stub.xml | 6 +++--- vector/src/main/res/layout/item_timeline_read_marker.xml | 4 +++- vector/src/main/res/layout/item_tos.xml | 3 ++- vector/src/main/res/layout/item_unknown_room.xml | 3 ++- vector/src/main/res/layout/item_uploads_file.xml | 3 ++- vector/src/main/res/layout/item_uploads_image.xml | 3 ++- vector/src/main/res/layout/item_uploads_video.xml | 3 ++- vector/src/main/res/layout/item_user.xml | 3 ++- .../res/layout/item_user_directory_letter_header.xml | 3 ++- vector/src/main/res/layout/item_user_list_header.xml | 3 ++- vector/src/main/res/layout/item_verification_action.xml | 3 ++- .../src/main/res/layout/item_verification_big_image.xml | 4 +++- .../main/res/layout/item_verification_decimal_code.xml | 3 ++- vector/src/main/res/layout/item_verification_emojis.xml | 3 ++- vector/src/main/res/layout/item_verification_notice.xml | 3 ++- vector/src/main/res/layout/item_verification_qr_code.xml | 3 ++- vector/src/main/res/layout/item_verification_wait.xml | 3 ++- vector/src/main/res/layout/item_verification_waiting.xml | 3 ++- vector/src/main/res/layout/item_vertical_margin.xml | 4 +++- vector/src/main/res/layout/item_zero.xml | 4 +++- vector/src/main/res/layout/reaction_button.xml | 2 +- .../main/res/layout/vector_home_badge_unread_layout.xml | 3 ++- 157 files changed, 345 insertions(+), 171 deletions(-) diff --git a/vector/src/debug/res/layout/item_sas_emoji.xml b/vector/src/debug/res/layout/item_sas_emoji.xml index a6a0e280580..6c9f6cd46d5 100644 --- a/vector/src/debug/res/layout/item_sas_emoji.xml +++ b/vector/src/debug/res/layout/item_sas_emoji.xml @@ -8,7 +8,8 @@ android:layout_marginEnd="16dp" android:layout_marginBottom="4dp" android:gravity="center_vertical" - android:orientation="horizontal"> + android:orientation="horizontal" + tools:viewBindingIgnore="true"> + tools:showIn="@layout/activity_emoji_reaction_picker" + tools:viewBindingIgnore="true"> + android:layout_height="wrap_content" + tools:viewBindingIgnore="true"> + android:background="@android:color/black" + tools:viewBindingIgnore="true"> + card_view:cardElevation="0dp" + tools:viewBindingIgnore="true"> + android:paddingBottom="6dp" + tools:viewBindingIgnore="true"> + android:padding="8dp" + tools:viewBindingIgnore="true"> + android:padding="8dp" + tools:viewBindingIgnore="true"> + android:textColor="?vctr_content_secondary" + tools:viewBindingIgnore="true" /> diff --git a/vector/src/main/res/layout/item_bottom_sheet_action.xml b/vector/src/main/res/layout/item_bottom_sheet_action.xml index d23dc5e1d82..bffcb79df64 100644 --- a/vector/src/main/res/layout/item_bottom_sheet_action.xml +++ b/vector/src/main/res/layout/item_bottom_sheet_action.xml @@ -12,7 +12,8 @@ android:paddingStart="@dimen/layout_horizontal_margin" android:paddingTop="8dp" android:paddingEnd="@dimen/layout_horizontal_margin" - android:paddingBottom="8dp"> + android:paddingBottom="8dp" + tools:viewBindingIgnore="true"> + android:paddingBottom="8dp" + tools:viewBindingIgnore="true"> diff --git a/vector/src/main/res/layout/item_bottom_sheet_message_preview.xml b/vector/src/main/res/layout/item_bottom_sheet_message_preview.xml index a86c0defc4f..771d4d10f09 100644 --- a/vector/src/main/res/layout/item_bottom_sheet_message_preview.xml +++ b/vector/src/main/res/layout/item_bottom_sheet_message_preview.xml @@ -5,7 +5,8 @@ android:id="@+id/bottom_sheet_message_preview" android:layout_width="match_parent" android:layout_height="wrap_content" - tools:background="#1FF00FF0"> + tools:background="#1FF00FF0" + tools:viewBindingIgnore="true"> + android:layout_marginBottom="4dp" + tools:viewBindingIgnore="true"> + android:padding="8dp" + tools:viewBindingIgnore="true"> + android:paddingBottom="8dp" + tools:viewBindingIgnore="true"> + android:layout_height="wrap_content" + tools:viewBindingIgnore="true"> + android:paddingBottom="8dp" + tools:viewBindingIgnore="true"> + android:foreground="?attr/selectableItemBackground" + tools:viewBindingIgnore="true"> \ No newline at end of file + tools:text="@string/matrix_only_filter" + tools:viewBindingIgnore="true" /> \ No newline at end of file diff --git a/vector/src/main/res/layout/item_completion_homeserver.xml b/vector/src/main/res/layout/item_completion_homeserver.xml index d0cb9f74df3..5ef6443f3a6 100644 --- a/vector/src/main/res/layout/item_completion_homeserver.xml +++ b/vector/src/main/res/layout/item_completion_homeserver.xml @@ -11,4 +11,5 @@ android:paddingStart="16dp" android:paddingEnd="16dp" android:textColor="?android:attr/textColorAlertDialogListItem" - tools:text="https://matrix.org" /> \ No newline at end of file + tools:text="https://matrix.org" + tools:viewBindingIgnore="true" /> \ No newline at end of file diff --git a/vector/src/main/res/layout/item_contact_action.xml b/vector/src/main/res/layout/item_contact_action.xml index 07e06f0d0ca..35192a1f049 100644 --- a/vector/src/main/res/layout/item_contact_action.xml +++ b/vector/src/main/res/layout/item_contact_action.xml @@ -7,7 +7,8 @@ android:background="?attr/selectableItemBackground" android:orientation="horizontal" android:paddingStart="8dp" - android:paddingEnd="8dp"> + android:paddingEnd="8dp" + tools:viewBindingIgnore="true"> + android:padding="8dp" + tools:viewBindingIgnore="true"> + android:paddingEnd="8dp" + tools:viewBindingIgnore="true"> + android:padding="8dp" + tools:viewBindingIgnore="true"> + android:padding="8dp" + tools:viewBindingIgnore="true"> + android:padding="16dp" + tools:viewBindingIgnore="true"> + android:paddingEnd="8dp" + tools:viewBindingIgnore="true"> + tools:layout_height="100dp" + tools:viewBindingIgnore="true" /> diff --git a/vector/src/main/res/layout/item_divider_on_surface.xml b/vector/src/main/res/layout/item_divider_on_surface.xml index 531d5860b2c..52c6b50d0d1 100644 --- a/vector/src/main/res/layout/item_divider_on_surface.xml +++ b/vector/src/main/res/layout/item_divider_on_surface.xml @@ -4,4 +4,5 @@ android:layout_width="match_parent" android:layout_height="1dp" android:background="?vctr_list_separator_on_surface" - tools:layout_height="100dp" /> + tools:layout_height="100dp" + tools:viewBindingIgnore="true" /> diff --git a/vector/src/main/res/layout/item_editable_avatar.xml b/vector/src/main/res/layout/item_editable_avatar.xml index 794cb9c9eb5..5676b65af81 100644 --- a/vector/src/main/res/layout/item_editable_avatar.xml +++ b/vector/src/main/res/layout/item_editable_avatar.xml @@ -6,7 +6,8 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:background="?android:colorBackground" - android:padding="16dp"> + android:padding="16dp" + tools:viewBindingIgnore="true"> + android:padding="16dp" + tools:viewBindingIgnore="true"> + android:paddingEnd="@dimen/layout_horizontal_margin" + tools:viewBindingIgnore="true"> + android:padding="16dp" + tools:viewBindingIgnore="true"> + android:padding="16dp" + tools:viewBindingIgnore="true"> + android:paddingBottom="12dp" + tools:viewBindingIgnore="true"> + android:minHeight="@dimen/item_form_min_height" + tools:viewBindingIgnore="true"> + android:minHeight="64dp" + tools:viewBindingIgnore="true">