Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update asar dep to ~0.11.0 #83

Closed
feross opened this issue May 8, 2016 · 1 comment
Closed

Update asar dep to ~0.11.0 #83

feross opened this issue May 8, 2016 · 1 comment

Comments

@feross
Copy link
Contributor

feross commented May 8, 2016

To fix the following install warning:

npm WARN deprecated [email protected]: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.
@feross feross changed the title Update asar dep to 0.11.0 Update asar dep to ~0.11.0 May 8, 2016
@fasterthanlime
Copy link
Contributor

fasterthanlime commented May 10, 2016 •
edited
Loading

Why this matters:

  • graceful-fs@3 re-evals fs's source code
  • as of Node 7.x, this will break (right now it's just a warning)
  • graceful-fs@4 and up just return a different object instead, so it doesn't have that problem.

Submitting a PR 🌠

@fasterthanlime fasterthanlime mentioned this issue May 10, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@feross @fasterthanlime