-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Installer Hanging on Mono Command #55
Comments
Please try update mono ( |
|
Still hanging with:
|
Is your app config is simple? Or custom? Please specify CPU and RAM of your Mac (well... on slow machine it can took 15 minutes...) |
Interesting, I'll let it run for a while longer and see what happens. It's a Late 2013 Macbook Pro with 2.4 GHz i5 and 8GB Ram. As for the app config, it's pretty simple - the mac installer from |
If it's helpful, I'm running electron builder with the following command:
|
Why app (do you use two-package json project structure?) is located under |
I'm using two package.json project structure - Here's where the config is a bit fancy - although again, everything here worked with my dmg installed. I do have a I'll give it a try using my app directory itself, though, and let you know if that works for me. I'm also going to try to let the mono command run for a while now that it's been updated. How long does it take on a quick machine? |
It seems that your setup is correct. Please provide full debug log (including nuspec template).
It takes 20 secs on my iMac (Retina 5K, 27-inch, Late 2015), on your Late 2013 Macbook Pro it should take < 2 minutes. New version of electron-builder will be in a few hours. Maybe it will help. |
|
Just to be sure: |
|
Please try 3.1.2 (will be published in 5 minutes). If still hangs, is it possible to send me a project? |
No luck. Perhaps related to NuGet/Home#348? |
Okay, running for 25 min:
Additionally, I ran the mono command independently and that appeared to successfully create a nupkg (after about 17 minutes)... |
@paulcbetts Why we use nuget 2.x if nuget 3 is available? |
@danlopez Try to grab latest nuget.exe 3.4.0-rc (https://dist.nuget.org/win-x86-commandline/v3.4.0-rc/nuget.exe) and replace existing in the electron-builder tests passed, so, I don't understand why 2 is used if 3 is available. I hope @kevinsawicki or @paulcbetts shed light on this. |
@danlopez |
@develar NuGet 3.x is broken and weird |
@paulcbetts Tests passed and application runs. Could you please clarify? I read http://praeclarum.org/post/128347388533/my-complaints-with-nuget-3 and did not understand. Maybe it is related to NET world, but to pack electron app is ok (if NuGet will pack faster than 2.x)? Or do you mean that Squirrel.Windows supports only 2.x packages? |
Squirrel itself embeds a fork of NuGet 2.x, but actually doesn't use it to unzip packages because it's too slow. I'm not excited to change this aspect of Squirrel, we'll probably move to some other distribution format tbh because for example, 7zip is cross-platform and compresses Electron to 1/2 the size. If you want to upgrade the vendored |
@paulcbetts Thanks for explanation.
Yeah... That will be cool. Squirrel.mac uses ZIP and doesn't require additional slow tool. BTW, to compress Linux DEB we use xz and it provides the best compression. I will also try to use Octo instead of NuGet. |
@develar - no luck with the beta release. I haven't tried to use the 3.x release, but I can give that a shot as well. It sounds like Octo also may be a decent substitute. Do you have a command you've been running in octo for this? |
@danlopez |
No. I am going to get rid of NuGet and zip files directly. It is possible to create nupkg file without additional tools, so, I think it will be a solution (but again — debug log is required, please provide it). |
@develar - sorry for the delay. Here's what happens the latest run. I'm omitting the earlier part of the log, but let me know if it's useful.
|
^^ This was using an asar archive following a comment about Windows path lengths that I read elsewhere. Looks to be an improvement, but still failing, as you can see. |
@danlopez I see that Squirrel.windows is not an issue (19 seconds). As expected, it seems, it is nuget pack issue. I am sure that part of the log doesn't contain important information — nuspec, spawn of nuget. Please provide full log (you can send by email if you don't want to share it here).
path of the log doesn't show error. And this issue about slow (10 minutes) nuget pack, right? |
@develar - I removed and reinstalled all of my node_modules (which includes the electron-winstaller-fixed 2.0.6-beta.7 dependency of electron-builder) and the runtime no longer became an issue - it's getting through Squirrel.windows just fine. It's actually failing at the last line of the log ( Looks like it's getting closer... |
|
Yup - you're right. it looks like that run actually produced an Installer. Testing it now, but I'm going to close this - it's definitely gotten past the hanging mono. I'm not sure what fixed it, but it could be one of the following:
@develar - thanks so much for your help getting through this! |
electron-builder does the best for you and this option is enabled by default.
It will be cool if you remove |
No problem. Will give that a try and let you know. |
In the next electron-builder release it is fixed — we don't use nuget to pack anymore. 4x-8x speedup. PR to windows-installer will be this/next week. |
I am going to create installer electron app following https://www.youtube.com/watch?v=IuYFDwPKE3c. Tiger@DESKTOP-JMF3JE8 MINGW64 ~/Desktop/workspace/electron |
@Nowaker Just use electron-builder. |
@develar What do you mean? Or... why? |
@Nowaker electron-builder can build for or Squirrel.Windows (not recommended), or nsis installer (default target). electron-builder doesn't use nuget to produce Squirrel.Windows installer. |
@develar Thanks. I've had a look and looks impressive. (FYI - I was asked by a colleague to help them with making their builds automated on CI, and that's how they did it - electron-builder + electron-winstaller, now I'm wondering why) |
Before using electron-builder, I tried with |
FWIW, I also had to set |
I'm using windows-installer through electron-builder. My installation appears to be hanging at the step seen in https://github.com/electron/windows-installer/blob/master/src/index.js#L151. I'm running
windows-installer
with the debug flag, and I very quickly get to the output for 'Created NuSpec file'.Running ps | grep mono, I see that the mono pack command continues to run indefinitely (At the time of writing this, it's been going for over 10 minutes). Any ideas what might be causing this? I'm running this on a mac and have installed mono using brew. Mono version is 4.2.0.
The text was updated successfully, but these errors were encountered: