Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon inconsistency #29

Closed
jkudish opened this issue Mar 6, 2016 · 5 comments
Closed

Icon inconsistency #29

jkudish opened this issue Mar 6, 2016 · 5 comments

Comments

@jkudish
Copy link

jkudish commented Mar 6, 2016

Pretty minor thing, but iconUrl accepts a URL whereas setupIcon accepts a local resource. It would be nice if they could both accept a URL.

Also this could be better documented (happy to submit a PR for that later)
@lukeapage
Copy link
Contributor

yeah I noticed this and didn't understand why it needed to be a URL.

Looking at https://docs.nuget.org/create/nuspec-reference I can see it is used for the manage nuget packages dialogue - if its not used anywhere else, is this option only for people publishing on nuget?

@astoilkov
Copy link

Anyone have answers to these questions? I am also wondering.

@develar
Copy link
Contributor

develar commented Mar 17, 2016

Related: electron-archive/grunt-electron-installer#73

@lukeapage lukeapage mentioned this issue Apr 2, 2016
Closed
@develar
Copy link
Contributor

develar commented Apr 3, 2016

NuGet issue — NuGet/Home#352

@havenchyk
Copy link
Contributor

Cannot be fixed since it's a nuget issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jkudish @lukeapage @develar @astoilkov @havenchyk