Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention rcedit.exe dependency requirement for building for Windows in readme #57

Closed
junosuarez opened this issue Jun 1, 2015 · 2 comments
Closed

Mention rcedit.exe dependency requirement for building for Windows in readme #57

junosuarez opened this issue Jun 1, 2015 · 2 comments
Labels
enhancement Feature request

Comments

@junosuarez
Copy link
Contributor

re #53 (comment)

The readme should say how to get rcedit and make sure it's available to electron-packager
@junosuarez junosuarez added enhancement Feature request help wanted Needs a contributor from the community labels Jun 1, 2015
@junosuarez
Copy link
Contributor Author

The npm package for node-rcedit comes with the bin/rcedit.exe - this is the best way for us to distribute it. When building from non-Windows platforms, it runs under wine, as we mention in our readme.

@junosuarez
Copy link
Contributor Author

Closing this issue, as no additional step should be necessary for rcedit as a dependency beyond npm install

@malept malept removed the help wanted Needs a contributor from the community label Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@malept @junosuarez