-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packager stops without any messages on a Windows host platform #544
Comments
Hrm. Try setting |
Thanks @malept , did not know about Here is the gist: https://gist.github.com/ZoolWay/bee85209aacc45e4114de155b78919f5 To me looks like it is just stopping in the middle of things. |
That is extremely strange. The last two debug lines should be flipped, for one. It looks like your temporary directory is on a different drive than your app's working directory. Could you try having your working directory on the same drive as your temporary directory? (It shouldn't matter, but I have a bad feeling about this.) |
I updated the gist using the Also I moved the folder directly under |
I still think this is Windows-specific. Is it possible to try with a different host platform? (keep the target the same) |
I have now tried a different machine but I only got Win 10 machines here. The same result. Also note that the same command line works for the electron-quickstart project (cloned, npm installed, packaged) - so I am not sure. Failing the packaging without any error, thats really strange. I might be able to test it in a Linux VM but not before Sunday. But you could try with my repo by yourself if you got a minute to spare ( https://github.com/ZoolWay/electron-typescript-aurelia-starter ). Otherwise I will come back after a Linux test. Let me know if I can try something else or make it more verbose in any way. |
Ok, found an old VM with Ubuntu and installed nodejs, etc. plus wine. Building the linux package works and building the win32-x86 package works there too. I updated the gist with the log ( |
Fair warning, since this appears to be a Windows-specific issue, it may be a while before I find the time to boot up a Windows VM and debug this. If you would to try debugging this yourself, this is what I'm going to do: put a bunch of |
Interestingly, this also fails using https://github.com/Microsoft/BashOnWindows |
Yeah, I imagine it's Windows-internals-specific. I still haven't found time to debug this and would appreciate someone else who's motivated to follow the instructions in my earlier comment and post the results here. |
then it is crashed for no reason and no error log appears.i am looking for a solution to package |
That's not what that deprecation message means. Use I still need a volunteer to debug this. |
i dont know if this help. i add flag with --ignore=node_,modules. it solves all my problem. |
I tried |
It would really help if someone could make a minimal testcase that reproduces the problem. Using the |
@englishextra that doesn't actually reproduce the problem. You need to modify electron-quick-start to be packageable. |
@malept I was not going to reproduce the problem. I just confirmed that quick start works and placed the log of cmd for you to see the deps so that you can have the picture. The case is particular so the dev only knows where to dig into. |
I am experiencing the same problem on Windows 10 64 bit. Packaging the same project works fine on OSX. Here is my log: https://gist.github.com/arekkas/bee174bac37357a8910f48693fd5a1b7 |
To be clear to future commenters: this only affects Windows. @arekkas thank you for the log. This confirms my suspicion from my earlier comment. Someone who has this problem, please try the following: put a bunch of debug statements in the |
My suspicion is a long path issue in one of the node modules. Nothing concrete yet though. |
@malept so apparently we make it past the last statement in initializeApp()
// ...
series(operations, function (err) {
console.log('cb err', err) // this is never being called
if (err) return callback(err)
callback(null, tempPath)
})
console.log('end') // this gets executed
}, but we're not making it in the callback in createApp: function createApp (opts, templatePath, callback) {
common.initializeApp(opts, templatePath, path.join('resources', 'app'), function buildWinApp (err, tempPath) {
console.log('init cb') // we don't make it until here |
I've tried this hack to debug which operation is causing the trouble, it seems like it's operation 1: series(operations.map((o, k) => (args) => {
console.log('operation', k) // prints "operation 0", "operation 1"
return o(args)
}), function (err) {
if (err) return callback(err)
callback(null, tempPath)
}) |
@malept yes, it's the second. although it seems that we're finishing that one too. my guess is that |
|
Ah, scrap my last comment. It was caused by me removing the options from |
Could this be the cause? |
@arekkas Nope, I haven't even released that yet 😄 |
Ok, damnit. :D So I just tried this: try {
fs.copy(opts.dir, appPath, {filter: ignore.userIgnoreFilter(opts), dereference: shouldDeref}, () => {
console.log('GOT CALLED BACK')
})
} catch (e) {
console.error(e)
} which yields...nothing. So I guess it's something with the copy task that doesn't call the callback properly. |
@arekkas just for completeness's sake, could you try with Electron Packager master? I want to make sure it's still a problem in the latest |
how does that work, |
I investigated if the issue is with spaces in the path ( |
I think you can just say |
Adding Unfortunately, the issue persists on the master branch. |
upstream: jprichardson/node-fs-extra#358 Let's see what they say. |
@arekkas thanks for filing the issue, it is greatly appreciated. |
Thank you for being so responsive, not a lot of maintainers are! |
Try upgrading to node 7.6.0. It seems to be working with that one! |
Any leads on this one? I'm stuck with the same issue for one of my projects. But my another project for win32 is completing without any issue. |
Evidently, try the latest Node 7. |
I updated to Node 7.7.2 and it is now working as expected. Now that's a relief. Thanks! |
I'm going to close this, since there's a workaround and it appears to be a Node problem, not an Electron Packager problem. |
I don't know why but
With it :
|
Adding |
When I try to package my simple application ( https://github.com/ZoolWay/electron-typescript-aurelia-starter ) I run:
Then it finishes without anything else to say. I am back at my console shell, no output generated.
As you see I call it like this:
The pure electron-quick-start works but not with this project of myself. Most confusing is exiting without any error message.
The text was updated successfully, but these errors were encountered: