-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename --version to --electron-version #154
Comments
I'd rather try and fix this with docs first. The readme formatting could use some love, e.g. the usage section is currently a big wall of unicode text |
I figured as much. I just wanted to get this idea out there and documented. I'll take a crack at making the README friendlier tonight, if I have some time. Closing for now. |
I'm reopening this. No amount of docs has fixed this so far. In my opinion, this option violates the principle of least astonishment. Here's the specification for how this should work:
|
There seem to be a disproportionate number of issues created over the confusion around what
--version
actually means. (See: #137, #140, #153.) I propose that the parameter be renamed so that it's obvious as to what the flag's value refers to: the version of Electron, not the version of the application.This would obviously be a breaking change, requiring a major version bump.
The text was updated successfully, but these errors were encountered: