MAS crash with allow-unsigned-executable-memory entitlement on High Sierra

[TonyWuu]

Building MAS on Catalina, our app crashed on launch due to

# Fatal process OOM in CodeRange setup: allocate virtual memory

This is caused by codesigning the Electron (GPU) and (Renderer) helper apps with hardened runtime. After reading through a similar issue in electron/electron#20560, I added the entitlement com.apple.security.cs.allow-unsigned-executable-memory to the child entitlements, and was able to get it working and submitted/approved to the MAS.

However, we then noticed after getting hundreds of reports in the App Store that adding this entitlement caused insta-crashes on launch in High Sierra (but not Mojave). The error:

FATAL:gpu_data_manager_impl_private.cc(1034)] The display compositor is frequently crashing. Goodbye.
Trace/BPT trap: 5

I found a similar report in electron/electron#18066 and electron/electron#19626 which suggests it's an issue caused by the GPU process being sandboxed, but it hasn't come to a resolution yet, but I'm starting to doubt whether adding the entitlement was the right solution in the first place. If I can resolve the first issue of signing the helper apps with hardened runtime without needing to add the extra entitlement, it would be a workaround for getting our app working again for High Sierra users and Catalina users. Another user also fixed this by removing the entitlement electron/electron#22656 (comment). Any suggestions? Or is this simply a High Sierra bug that needs to be fixed in Electron?

Anyone else face similar problems?

[MarshallOfSound]

Duplicate of #188, we need better defaults for our helper entitlements