From d7514d0a0c3216d1e846049b911873b9375f1d79 Mon Sep 17 00:00:00 2001
From: Shiqi Yang <shiqi@slack-corp.com>
Date: Wed, 25 Sep 2019 12:11:02 -0700
Subject: [PATCH] review feedback

---
 README.md                       | 7 ++++---
 bin/electron-osx-sign-usage.txt | 3 ++-
 sign.js                         | 4 +---
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/README.md b/README.md
index 7c0d648..bdb71a2 100644
--- a/README.md
+++ b/README.md
@@ -224,10 +224,11 @@ Default to `undefined`.
 
 `restrict` - *Boolean*
 
-*** To be deprecated, see `signature-flags` *** Restrict dyld loading. See doc about this [code signature flag](https://developer.apple.com/documentation/security/seccodesignatureflags/kseccodesignaturerestrict?language=objc) for more details. Disabled by default.
+**To be deprecated, see `signature-flags`.** 
+Restrict dyld loading. See doc about this [code signature flag](https://developer.apple.com/documentation/security/seccodesignatureflags/kseccodesignaturerestrict?language=objc) for more details. Disabled by default.
 
-`signature-flags` - *String|String[]*
-comma separated string or array for [code signature flag](https://developer.apple.com/documentation/security/seccodesignatureflags?language=objc). Default is `undefined`
+`signature-flags` - *String*
+Comma separated string or array for [code signature flag](https://developer.apple.com/documentation/security/seccodesignatureflags?language=objc). Default to `underfined`
 
 `strict-verify` - *Boolean|String|Array.<String>*
 
diff --git a/bin/electron-osx-sign-usage.txt b/bin/electron-osx-sign-usage.txt
index ef42af8..3bff28f 100644
--- a/bin/electron-osx-sign-usage.txt
+++ b/bin/electron-osx-sign-usage.txt
@@ -64,7 +64,8 @@ DESCRIPTION
     Specify the criteria that you recommend to be used to evaluate the code signature.
 
   --restrict
-    Flag to enable restrict mode. Disabled by default. (this will be deprecated soon, see --sign-flags)
+    (This will be deprecated soon, see --sign-flags.)
+    Flag to enable restrict mode. Disabled by default. 
 
   --signature-flags=flags
     Code signature flags. Default to none.
diff --git a/sign.js b/sign.js
index ec3e567..27f9ab3 100644
--- a/sign.js
+++ b/sign.js
@@ -165,9 +165,7 @@ function signApplicationAsync (opts) {
           optionsArguments = [...opts['signature-flags']]
         } else {
           const flags = opts['signature-flags'].split(',').map(function (flag) { return flag.trim() })
-          flags.forEach(element => {
-            optionsArguments.push(element)
-          })
+          optionsArguments = [...flags]
         }
       }