From 768c3920c4cb4a3cceefbefd874a8fa4b443e93a Mon Sep 17 00:00:00 2001 From: Zhuo Lu Date: Mon, 9 Sep 2019 16:45:38 -0700 Subject: [PATCH 1/4] Update test doc --- README.md | 72 ++++++++++++------------------------------------------- 1 file changed, 15 insertions(+), 57 deletions(-) diff --git a/README.md b/README.md index 48cc3c2..c3a6155 100644 --- a/README.md +++ b/README.md @@ -374,13 +374,9 @@ As of release v0.3.1, external module `debug` is used to display logs and messag ## Test -As developer certificates are required for `codesign` on macOS, this module is difficult to be tested via online build services. If you wish to test out this module, enter: +The project's configured to run automated tests on CircleCI. -``` -npm test -``` - -from the dev directory, and tell us if all tests should pass. +If you wish to manually test the module, first comment out `opts.identity` in `test/basic.js` to enable auto discovery. Then run the command `npm test` from the dev directory. When this command is fun for the first time: `electron-download` will download all major releases of Electron available for macOS from 0.24.0, and save to `~/.electron/`, which might take up less than 1GB of disk space. @@ -399,69 +395,31 @@ Calling electron-download before running tests... Running tests... TAP version 13 # setup -# defaults-test:v0.29.2-darwin-x64 +# defaults-test:v7.0.0-beta.3-darwin-x64 ok 1 app signed -# defaults-test:v0.30.8-darwin-x64 +# defaults-test:v7.0.0-beta.3-mas-x64 ok 2 app signed -# defaults-test:v0.31.2-darwin-x64 +# defaults-test:v6.0.3-darwin-x64 ok 3 app signed -# defaults-test:v0.32.3-darwin-x64 +# defaults-test:v6.0.3-mas-x64 ok 4 app signed -# defaults-test:v0.33.9-darwin-x64 +# defaults-test:v5.0.10-darwin-x64 ok 5 app signed -# defaults-test:v0.34.5-darwin-x64 +# defaults-test:v5.0.10-mas-x64 ok 6 app signed -# defaults-test:v0.34.5-mas-x64 +# defaults-test:v4.2.9-darwin-x64 ok 7 app signed -# defaults-test:v0.35.6-darwin-x64 +# defaults-test:v4.2.9-mas-x64 ok 8 app signed -# defaults-test:v0.35.6-mas-x64 +# defaults-test:v3.1.2-darwin-x64 ok 9 app signed -# defaults-test:v0.36.12-darwin-x64 +# defaults-test:v3.1.2-mas-x64 ok 10 app signed -# defaults-test:v0.36.12-mas-x64 -ok 11 app signed -# defaults-test:v0.37.8-darwin-x64 -ok 12 app signed -# defaults-test:v0.37.8-mas-x64 -ok 13 app signed -# defaults-test:v1.0.2-darwin-x64 -ok 14 app signed -# defaults-test:v1.0.2-mas-x64 -ok 15 app signed -# defaults-test:v1.1.3-darwin-x64 -ok 16 app signed -# defaults-test:v1.1.3-mas-x64 -ok 17 app signed -# defaults-test:v1.2.8-darwin-x64 -ok 18 app signed -# defaults-test:v1.2.8-mas-x64 -ok 19 app signed -# defaults-test:v1.3.7-darwin-x64 -ok 20 app signed -# defaults-test:v1.3.7-mas-x64 -ok 21 app signed -# defaults-test:v1.4.15-darwin-x64 -ok 22 app signed -# defaults-test:v1.4.15-mas-x64 -ok 23 app signed -# defaults-test:v1.6.17-darwin-x64 -ok 24 app signed -# defaults-test:v1.6.17-mas-x64 -ok 25 app signed -# defaults-test:v1.7.12-darwin-x64 -ok 26 app signed -# defaults-test:v1.7.12-mas-x64 -ok 27 app signed -# defaults-test:v1.8.3-darwin-x64 -ok 28 app signed -# defaults-test:v1.8.3-mas-x64 -ok 29 app signed # teardown -1..29 -# tests 29 -# pass 29 +1..10 +# tests 10 +# pass 10 # ok ``` From f44f208fb34552af093cf18e88ed2e060fd3620e Mon Sep 17 00:00:00 2001 From: Zhuo Lu Date: Mon, 9 Sep 2019 16:46:01 -0700 Subject: [PATCH 2/4] Update .gitignore --- .gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index c43010b..a532d05 100644 --- a/.gitignore +++ b/.gitignore @@ -4,6 +4,6 @@ /node_modules/ -/package-json.lock +/package-lock.json /test/work/ From ec95e97189069451f18a3b4ebf40e5a488b87697 Mon Sep 17 00:00:00 2001 From: Zhuo Lu Date: Mon, 9 Sep 2019 16:52:28 -0700 Subject: [PATCH 3/4] Fix typo --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index c3a6155..da15f62 100644 --- a/README.md +++ b/README.md @@ -378,7 +378,7 @@ The project's configured to run automated tests on CircleCI. If you wish to manually test the module, first comment out `opts.identity` in `test/basic.js` to enable auto discovery. Then run the command `npm test` from the dev directory. -When this command is fun for the first time: `electron-download` will download all major releases of Electron available for macOS from 0.24.0, and save to `~/.electron/`, which might take up less than 1GB of disk space. +When this command is run for the first time: `electron-download` will download all major releases of Electron available for macOS from 0.24.0, and save to `~/.electron/`, which might take up less than 1GB of disk space. A successful testing should look something like: From 17b3bf161abf9e9debd450569d297c3dcc824652 Mon Sep 17 00:00:00 2001 From: Zhuo Lu Date: Mon, 9 Sep 2019 16:53:42 -0700 Subject: [PATCH 4/4] A bit more precise about which versions are tested --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index da15f62..91f70be 100644 --- a/README.md +++ b/README.md @@ -378,7 +378,7 @@ The project's configured to run automated tests on CircleCI. If you wish to manually test the module, first comment out `opts.identity` in `test/basic.js` to enable auto discovery. Then run the command `npm test` from the dev directory. -When this command is run for the first time: `electron-download` will download all major releases of Electron available for macOS from 0.24.0, and save to `~/.electron/`, which might take up less than 1GB of disk space. +When this command is run for the first time: `electron-download` will download macOS Electron releases defined in `test/config.json`, and save to `~/.electron/`, which might take up less than 1GB of disk space. A successful testing should look something like: