Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated contributing.md #3394

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

bhargavshirin
Copy link
Contributor

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
fixed typo in contributing.md

@bhargavshirin bhargavshirin requested a review from a team as a code owner October 30, 2023 10:13
@berlintay
Copy link

add

docs: update to pr title 👍

@berlintay
Copy link

add

docs: update to pr title 👍

or actually

have a look here


Annotations
1 error
Validate PR Title
No release type found in pull request title "Update CONTRIBUTING.md". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:

  • feat: A new feature
  • fix: A bug fix
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
  • ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit

@bhargavshirin bhargavshirin changed the title Update CONTRIBUTING.md docs: updated contributing.md Oct 30, 2023
@bhargavshirin
Copy link
Contributor Author

done

Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bhargavshirin, thanks for this!

@erickzhao erickzhao merged commit 0a468c8 into electron:main Oct 30, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants