Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): update --help command output #3335

Merged
merged 3 commits into from
Sep 5, 2023
Merged

fix(cli): update --help command output #3335

merged 3 commits into from
Sep 5, 2023

Conversation

erickzhao
Copy link
Member

Uhhhh we don't have lint or install anymore as of some betas ago.

@erickzhao erickzhao marked this pull request as ready for review September 1, 2023 19:13
@erickzhao erickzhao requested a review from a team as a code owner September 1, 2023 19:13
malept
malept approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, just a nit about consistency

packages/api/cli/src/electron-forge.ts Outdated Show resolved Hide resolved
@erickzhao erickzhao merged commit 8a44cfd into main Sep 5, 2023
3 checks passed
@erickzhao erickzhao deleted the fix/prune-cli-help-commands branch September 5, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@dsanders11 dsanders11 dsanders11 approved these changes

@malept malept malept approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erickzhao @malept @dsanders11 @MarshallOfSound