Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(plugin-fuses): clear test TODOs #3306

Merged
merged 1 commit into from
Aug 20, 2023
Merged

test(plugin-fuses): clear test TODOs #3306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions packages/plugin/fuses/test/FusesPlugin_spec_slow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,7 @@ describe('FusesPlugin', () => {

const { name: appName } = packageJSON;

// @TODO get rid of this once https://github.com/electron/forge/pull/3123 lands
const platformArchSuffix = `${process.platform}-x64`;

const outDir = path.join(appPath, 'out', `${appName}-${platformArchSuffix}`);
const outDir = path.join(appPath, 'out', 'fuses-test-app');

before(async () => {
delete process.env.TS_NODE_PROJECT;
Expand All @@ -36,9 +33,6 @@ describe('FusesPlugin', () => {

after(async () => {
await fsExtra.remove(path.resolve(outDir, '../'));

// @TODO this can be removed once the mock app installs a published version of @electron-forge/plugin-fuses instead of a local package
await fsExtra.remove(path.join(__dirname, './fixture/app/node_modules'));
});

it('should flip Fuses', async () => {
Expand All @@ -51,6 +45,7 @@ describe('FusesPlugin', () => {
});

const args: string[] = process.platform === 'linux' ? ['-v', '--no-sandbox'] : ['-v'];

/**
* If the `RunAsNode` fuse had not been flipped,
* this would return the Node.js version (e.g. `v14.16.0`)
Expand Down
6 changes: 3 additions & 3 deletions packages/plugin/fuses/test/fixture/app/package.json.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
"fs-extra": "^10.0.0"
},
"devDependencies": {
"@electron-forge/cli": "6.0.5",
"@electron-forge/plugin-fuses": "file:./../../../../fuses",
"@electron-forge/shared-types": "6.0.5",
"@electron-forge/cli": "6.4.0",
"@electron-forge/plugin-fuses": "6.4.0",
"@electron-forge/shared-types": "6.4.0",
"electron": "12.0.0"
}
}