fix(core): allow the forge.config
property in package.json
to point to a non-js file
#3070
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
This PR makes it possible to specify a config file of any extension in the
config.forge
property ofpackage.json
. While #2993 allows for config files in extensions other than .js, they're only interpreted correctly if you don't specify theconfig.forge
property in yourpackage.json
- if you do, the file is interpreted as plain .js.This seems unexpected and can get on the way if one tries to migrate to, say, a .ts config file just by changing the extension in the
package.json
like this...... because Forge expects it to be .js and throws an error. Currently, the entire
config.forge
must be removed for Forge to use the correct loader forforge.config.ts
: