Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade electron-wix-msi to 4.0.0 #3003

Merged
merged 1 commit into from
Oct 26, 2022
Merged

chore: upgrade electron-wix-msi to 4.0.0 #3003

merged 1 commit into from
Oct 26, 2022

Conversation

georgexu99
Copy link
Contributor

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

@georgexu99 georgexu99 requested a review from erickzhao October 26, 2022 22:24
@georgexu99 georgexu99 requested a review from VerteDinde October 26, 2022 22:54
@VerteDinde VerteDinde merged commit c26a682 into main Oct 26, 2022
@VerteDinde VerteDinde deleted the gxu-upgrade-wix branch October 26, 2022 23:06
@georgexu99 georgexu99 changed the title build: upgrade electron-wix-msi to 4.0.0 chore: upgrade electron-wix-msi to 4.0.0 Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

@erickzhao erickzhao Awaiting requested review from erickzhao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@georgexu99 @VerteDinde @MarshallOfSound