Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add rule that enforces named exports over default exports #3000

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

MarshallOfSound
Copy link
Member

Missed a few in #2996 and found a handy rule so we don't miss any again

@MarshallOfSound MarshallOfSound requested a review from a team October 26, 2022 19:53
@MarshallOfSound MarshallOfSound force-pushed the enforce-named-over-default branch from 0af6502 to 44fc84f Compare October 26, 2022 19:57
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #3000 (44fc84f) into main (e404bf1) will increase coverage by 0.36%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3000      +/-   ##
==========================================
+ Coverage   73.91%   74.27%   +0.36%     
==========================================
  Files          67       67              
  Lines        2185     2185              
  Branches      438      438              
==========================================
+ Hits         1615     1623       +8     
+ Misses        356      354       -2     
+ Partials      214      208       -6     
Impacted Files Coverage Δ
packages/api/core/src/api/publish.ts 68.42% <ø> (ø)
packages/api/core/src/util/plugin-interface.ts 31.11% <100.00%> (ø)
packages/maker/base/src/Maker.ts 73.52% <0.00%> (+2.94%) ⬆️
packages/api/core/src/api/make.ts 79.20% <0.00%> (+5.94%) ⬆️
packages/maker/zip/src/MakerZIP.ts 100.00% <0.00%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e404bf1...44fc84f. Read the comment docs.

@MarshallOfSound MarshallOfSound merged commit 8fa40d4 into main Oct 26, 2022
@MarshallOfSound MarshallOfSound deleted the enforce-named-over-default branch October 26, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants