Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add / use named exports for plugins + makers + publishers #2996

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

MarshallOfSound
Copy link
Member

This is a small usability thing, importing a named import is a lot easier than a default export and this enforces consistent naming so that we can more easily read code supplied in bug reports.

@MarshallOfSound MarshallOfSound requested a review from a team October 26, 2022 10:34
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #2996 (2fb2045) into main (247bcc8) will increase coverage by 0.81%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2996      +/-   ##
==========================================
+ Coverage   73.38%   74.19%   +0.81%     
==========================================
  Files          67       67              
  Lines        2168     2178      +10     
  Branches      436      436              
==========================================
+ Hits         1591     1616      +25     
+ Misses        365      355      -10     
+ Partials      212      207       -5     
Impacted Files Coverage Δ
packages/api/core/src/api/make.ts 79.20% <100.00%> (+5.94%) ⬆️
packages/maker/appx/src/MakerAppX.ts 62.06% <100.00%> (+3.44%) ⬆️
packages/maker/base/src/Maker.ts 70.58% <100.00%> (+0.89%) ⬆️
packages/maker/deb/src/MakerDeb.ts 95.45% <100.00%> (+4.54%) ⬆️
packages/maker/dmg/src/MakerDMG.ts 100.00% <100.00%> (+5.00%) ⬆️
packages/maker/flatpak/src/MakerFlatpak.ts 79.16% <100.00%> (+0.90%) ⬆️
packages/maker/pkg/src/MakerPKG.ts 93.75% <100.00%> (+0.41%) ⬆️
packages/maker/rpm/src/MakerRpm.ts 95.45% <100.00%> (+4.54%) ⬆️
packages/maker/snap/src/MakerSnap.ts 100.00% <100.00%> (+6.66%) ⬆️
packages/maker/squirrel/src/MakerSquirrel.ts 77.27% <100.00%> (+1.08%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 247bcc8...2fb2045. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants