Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!(maker-pkg): upgrade to @electron/osx-sign #2959

Merged
merged 6 commits into from
Oct 13, 2022
Merged

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Oct 13, 2022

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Swaps out the old electron-osx-sign package for the newer @electron/osx-sign one. Closes #2957

Breaking change: identity-validation flag is camelCased to identityValidation now.

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #2959 (b7741f1) into main (f5a9d81) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2959      +/-   ##
==========================================
+ Coverage   71.07%   71.08%   +0.01%     
==========================================
  Files          78       78              
  Lines        2392     2393       +1     
  Branches      452      452              
==========================================
+ Hits         1700     1701       +1     
  Misses        469      469              
  Partials      223      223              
Impacted Files Coverage Δ
packages/maker/pkg/src/MakerPKG.ts 93.33% <100.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5a9d81...b7741f1. Read the comment docs.

@erickzhao erickzhao requested a review from a team October 13, 2022 03:54
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change: identity-validation flag is camelCased to identityValidation now.

Noting this in the release blog post

@VerteDinde VerteDinde merged commit dba9359 into main Oct 13, 2022
@VerteDinde VerteDinde deleted the pkg-upgrade branch October 13, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade maker-pkg to @electron/osx-sign
3 participants