Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(publisher-ers): support flavor config #2766

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Mar 17, 2022

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Closes #1215

Adds support for the flavor config in electron-release-server. This is an optional parameter for the ERS publisher. Also added a set of basic tests for the publisher.

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #2766 (784f669) into master (9026eae) will decrease coverage by 47.66%.
The diff coverage is 100.00%.

❗ Current head 784f669 differs from pull request most recent head eb0d2d0. Consider uploading reports for the commit eb0d2d0 to get more accurate results

@@             Coverage Diff             @@
##           master    #2766       +/-   ##
===========================================
- Coverage   73.93%   26.27%   -47.67%     
===========================================
  Files          77       73        -4     
  Lines        2356     2253      -103     
  Branches      436      423       -13     
===========================================
- Hits         1742      592     -1150     
- Misses        464     1654     +1190     
+ Partials      150        7      -143     
Impacted Files Coverage Δ
...lisher/electron-release-server/src/PublisherERS.ts 86.76% <100.00%> (+59.49%) ⬆️
...s/plugin/local-electron/src/LocalElectronPlugin.ts 10.00% <0.00%> (-90.00%) ⬇️
packages/api/core/src/util/upgrade-forge-config.ts 10.52% <0.00%> (-89.48%) ⬇️
packages/plugin/webpack/src/util/once.ts 11.11% <0.00%> (-88.89%) ⬇️
packages/maker/wix/src/util/author-name.ts 20.00% <0.00%> (-80.00%) ⬇️
packages/maker/appx/src/util/author-name.ts 20.00% <0.00%> (-80.00%) ⬇️
...ypescript-webpack/src/TypeScriptWebpackTemplate.ts 20.00% <0.00%> (-80.00%) ⬇️
packages/plugin/webpack/src/WebpackConfig.ts 18.98% <0.00%> (-79.75%) ⬇️
packages/api/core/src/util/publish-state.ts 12.82% <0.00%> (-79.49%) ⬇️
packages/api/core/src/util/rebuild.ts 16.66% <0.00%> (-78.08%) ⬇️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9026eae...eb0d2d0. Read the comment docs.

@erickzhao erickzhao requested a review from malept March 23, 2022 05:25
@erickzhao erickzhao force-pushed the feat/flavor-config branch from 784f669 to 79ed8b9 Compare March 23, 2022 17:04
@erickzhao erickzhao force-pushed the feat/flavor-config branch from 79ed8b9 to eb0d2d0 Compare March 23, 2022 17:12
@erickzhao erickzhao marked this pull request as ready for review March 23, 2022 18:28
@erickzhao erickzhao merged commit 6069ebe into master Apr 20, 2022
@erickzhao erickzhao deleted the feat/flavor-config branch April 20, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for "flavor" in the Electron Release Server publisher
2 participants