fix: escape file names for make step

[erickzhao]

• I have read the contribution documentation for this project.
• I agree to follow the code of conduct that this project follows, as appropriate.
• The changes are appropriately documented (if applicable).
• The changes have sufficient test coverage (if applicable).
• The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Fixes #1745

Stole some code from Packager which sanitizes file names:

function sanitizeAppName (name) {
  return filenamify(name, { replacement: '-' })
}

Note: the lockfile doesn't change here because we already had this exact version of filenamify as a transitive dep (via packager).

[codecov]

Codecov Report

Merging #2752 (e4c6a1f) into master (204ec25) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2752      +/-   ##
==========================================
+ Coverage   74.06%   74.07%   +0.01%     
==========================================
  Files          77       77              
  Lines        2356     2357       +1     
  Branches      436      436              
==========================================
+ Hits         1745     1746       +1     
  Misses        462      462              
  Partials      149      149              

Impacted Files	Coverage Δ
packages/api/core/src/api/make.ts	81.81% <100.00%> (+0.18%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 204ec25...e4c6a1f. Read the comment docs.

[MarshallOfSound]

This doesn't appear to have updated the lockfile

[malept]

It'd be nice if there were tests added for this.

[erickzhao]

oops this PR was not done. i wrangled proxyquire enough to write the worst test in the world. PTAL.

[erickzhao]

This doesn't appear to have updated the lockfile

@MarshallOfSound I grabbed this code change from Packager, which also uses the exact same "filenamify": "^4.1.0" dependency. I tested with other versions (e.g. bolt add filenamify@^4.0.0) and the yarn.lock changed.

I think since filenamify@^4.1.0 is already at the top-level in yarn.lock it's normal that it hasn't changed.

[malept]

Is the foo/null fixture necessary?

[erickzhao]

Is the foo/null fixture necessary?

I stole it from https://github.com/electron-userland/electron-forge/tree/master/packages/api/core/test/fixture/dummy_app and made changes accordingly.

Not sure if it's necessary, but it follows existing conventions from the repo.

[malept]

Is the foo/null fixture necessary?

I stole it from https://github.com/electron-userland/electron-forge/tree/master/packages/api/core/test/fixture/dummy_app and made changes accordingly.

Not sure if it's necessary, but it follows existing conventions from the repo.

It's probably not necessary. It's likely not necessary in dummy_app either but I'd have to do an audit for that one.

[erickzhao]

f5407a7 passed locally

[erickzhao]

e4c6a1f makes the test a bit better now that i understand things a bit better