Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-electronegativity): add parserPlugins option #2323

Merged
merged 1 commit into from
Jul 11, 2021
Merged

fix(plugin-electronegativity): add parserPlugins option #2323

merged 1 commit into from
Jul 11, 2021

Conversation

vhashimotoo
Copy link
Contributor

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

In the 1.8.0 version of Electronegativity (6 months old 😐), added the option parserPlugins, which for programmatic usage doesn't have a default value, this PR provides the default value which used in the CLI interface, an empty array. Not sure if this is an upstream bug, but if needed I can try to upstream this change.

@codecov
Copy link

codecov bot commented Jun 12, 2021

Codecov Report

Merging #2323 (1b056d4) into master (94b0f96) will increase coverage by 1.54%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2323      +/-   ##
==========================================
+ Coverage   74.04%   75.59%   +1.54%     
==========================================
  Files          74       74              
  Lines        2200     2200              
  Branches      413      413              
==========================================
+ Hits         1629     1663      +34     
+ Misses        460      421      -39     
- Partials      111      116       +5     
Impacted Files Coverage Δ
packages/maker/base/src/Maker.ts 75.67% <0.00%> (+2.70%) ⬆️
packages/api/core/src/api/make.ts 88.29% <0.00%> (+3.19%) ⬆️
packages/api/core/src/api/lint.ts 69.23% <0.00%> (+3.84%) ⬆️
packages/maker/zip/src/MakerZIP.ts 100.00% <0.00%> (+7.69%) ⬆️
packages/maker/appx/src/MakerAppX.ts 57.14% <0.00%> (+17.85%) ⬆️
packages/maker/squirrel/src/MakerSquirrel.ts 77.27% <0.00%> (+40.90%) ⬆️
packages/maker/wix/src/MakerWix.ts 86.36% <0.00%> (+40.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94b0f96...1b056d4. Read the comment docs.

@malept malept merged commit c7eff26 into electron:master Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants