Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publisher-electron-release-server fails to upload artifacts for other flavors than default #3078

Closed
3 tasks done
dariusclay opened this issue Nov 16, 2022 · 3 comments
Closed
3 tasks done

Comments

@dariusclay
Copy link
Contributor

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version

6.0.0-beta.68

Electron version

v16.2.8

Operating system

Windows 10 22H2

Last known working Electron Forge version

No response

Expected behavior

The forge publisher for electron release server should upload artifacts based on version, flavor and channel.

✔ Resolving publish target: @electron-forge/publisher-electron-release-server

✔ Uploading Artifacts 2/2

Actual behavior

When publishing versions for flavors other than default, an unhandled error has occurred inside Forge:
ERS publish failed with status code: 404

Steps to reproduce

Create a flavor other than "default" in electron release server.

Specify the flavor (for example "spicy") in forge publishers config:

publishers: [
  {
    name: "@electron-forge/publisher-electron-release-server",
    config: {
      baseUrl: "<url>",
      username: "<username>",
      password: "<password>",
      flavor: "spicy"
    },
  },
]

Additional information

I will submit a pull request available which fixes the issue.

@dariusclay
Copy link
Contributor Author

See: #3079

@ArekSredzki
Copy link
Contributor

This can now be closed, right?

@erickzhao
Copy link
Member

Yes, thank you @ArekSredzki !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants