-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify an Electron version when initializing a new project #246
Comments
@MarshallOfSound do you have any concerns about this feature request? |
@sarabsandhu You can just change the version in package.json and re-run |
@paulcbetts I have tried it and face issue described here |
@paulcbetts why request was closed? |
@paulcbetts , i have checked in my code at https://github.com/sarabsandhu/test-workstation.git if you want to reproduce the issue. I see below errors in dev tools when my initial window is launched Failed to parse SourceMap: file:///C:/Users/someuser/src/Observable.js.map I also tried to build the app for windows platform. it builds successfully but initial window is never launched. I can see the process running in task manager in windows. |
You can ignore this, it's just a warning
This is unrelated to this issue |
@paulcbetts , Should i open new issue for your comment "This is unrelated to this issue". If there is no issue with first error, then windows build should work/launch as it is when launched in dev mode with electron-forge start. Do you agree? |
@paulcbetts Changing the version in package.json doesn't work. The problem is the start script calls electron-prebuild-compile/lib/cli.js to spawn electron process. electron-prebuild-compile specifies electron1.8.somebetaversion as its dependency instead of having electron as a peer dependency. Therefore it doesn't matter what version you have in your package.json, electron1.8 will be used (which currently has a terrible bug that whenever you try to type in console it crashes on Windows) |
sorry, just noticed the original title. so the solution would be downgrading electron-prebuild-compile in my package.json. I presume its version is synced with the electron version it has as a dependency. |
That is correct 👍 |
I am wondering if I can specify version of electron-prebuilt-compile when initializing new project with electron-forge init. It automatically uses version 1.6.11 which has chrome version 56. My project requires chrome 51 which is present in 1.2.6. Please help if you know.
The text was updated successfully, but these errors were encountered: