Native modules were not rebuilt during package when webpack template is used

[jasonlaw-dev]

• I have read the contribution documentation for this project.
• I agree to follow the code of conduct that this project follows, as appropriate.
• I have searched the issue tracker for an issue that matches the one I want to file, without success.

Please describe your issue:

The issue is that this loader @marshallofsound/webpack-asset-relocator-loader relocates .node files before they get rebuilt.

npx create-electron-app my-new-app --template=webpack
cd my-new-app
npm i nan-hello-world

edit main.js by adding the following:

const helloworld = require('nan-hello-world');
console.log(helloworld.say())

Run npm run package without npm start

npm run package

When trying to open the packaged app, electron will warn that the native module was compiled against different version using NODE_MODULE_VERSION 64 instead of the required 73.

However, if you run the following

npm un nan-hello-world && npm i nan-hello-world
npm start
# close the app then run
npm run package

The app will run fine because the npm start has already rebuilt the module. @marshallofsound/webpack-asset-relocator-loader is relocating the rebuilt version of the .node files.

To get around this issue with CI tools, I need to manually run

npx electron-rebuild

before running package/make so that the correct .node files are being packed.

[ghost]

I"m seeing the same thing (i think). I have two native modules, but windows terminal output on appveyor shows this.

`019-08-04T10:44:25.119Z electron-rebuild rebuilding with args: C:\T\electron-packager\win32-x64\app-win32-x64\resources\app 6.0.0 x64 [] false https://electronjs.org/headers [ 'prod', 'optional' ] false
2019-08-04T10:44:25.119Z electron-rebuild identified prod deps: Set {}

It should show something other than an empty Set right?

EDIT: this is running the make command with DEBUG=electron-rebuild
`