fix(publisher-github): sanitizeName

electron · Sep 22, 2023 · b77a32b · b77a32b
1 parent 482db20
commit b77a32b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/packages/publisher/github/src/util/github.ts b/packages/publisher/github/src/util/github.ts
@@ -48,15 +48,14 @@ export default class GitHub {
     return github;
   }
 
-  // Based on https://developer.github.com/v3/repos/releases/#upload-a-release-asset and
+  // Based on https://docs.github.com/en/rest/releases/assets?apiVersion=2022-11-28#upload-a-release-asset and
   // https://stackoverflow.com/questions/59081778/rules-for-special-characters-in-github-repository-name
   static sanitizeName(name: string): string {
     return path
       .basename(name)
-      .replace(/\s/g, '.')
       .replace(/\.+/g, '.')
       .replace(/^\./g, '')
       .replace(/\.$/g, '')
-      .replace(/[^\w.-]/g, '-');
+      .replace(/[^\w.-]+/g, '-');
   }
 }
diff --git a/packages/publisher/github/test/github_spec.ts b/packages/publisher/github/test/github_spec.ts
@@ -112,11 +112,11 @@ describe('GitHub', () => {
     });
 
     it('should remove multiple periods in a row', () => {
-      expect(GitHub.sanitizeName('path/to/foo..bar')).to.equal('foobar');
+      expect(GitHub.sanitizeName('path/to/foo..bar')).to.equal('foo.bar');
     });
 
     it('should replace non-alphanumeric, non-hyphen characters with hyphens', () => {
-      expect(GitHub.sanitizeName('path/to/foo%bar baz.')).to.equal('foo-bar-baz');
+      expect(GitHub.sanitizeName('path/to/foo%$bar   baz.')).to.equal('foo-bar-baz');
     });
   });
 });