Fix ReDoS vulnerability in old dependency (CWE-400) #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajivshah3
changed the title
|
@rajivshah3 Thanks lots for making this PR! 😺 For some reasons I didn't get a notification last month. Merging this now... |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades
plistto v3.0.1. According to Snyk, versions prior to to v3.0.1 were vulnerable to a Regex Denial of Service attack. While this might not necessarily affectelectron-osx-sign, the current usage ofplistv2.1.0 could be causing dependency audit pipelines to fail (ours included) so it should be fixed imho. While this is a major version bump (from v2.1.0 to v3.0.1), according to the discussion on TooTallNate/plist.js#89 this only seems to be considered breaking because it caused them to drop support for Node v4.